Conditionally set disk UUID if empty in backing info #3896
Merged
+227
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the UUID was always set to a new value even if it was already present. This patch ensures that the disk UUID is now set only if it is
currently empty in the backing information.
How Has This Been Tested?
Made changes to govmomi pulled by vmware-tanzu/vm-operator#1258 and tested whether the UUID if set, remains same. With this patch, the expected behavior is validated.
Adds an unit test to validate the contract.
Guidelines
Please read and follow the
CONTRIBUTIONguidelines of this project.