Update packages to latest and align on NodeJS v18 and v20 and add missing ones #21
Description
Describe the feature
Some packages in the boilerplate are hardcoded to an exact version that should be the case!
@vue-storefront/middleware=> https://github.com/vuestorefront/integration-boilerplate/blob/main/playground/middleware/package.json#L12@vue-storefront/sdk=> https://github.com/vuestorefront/integration-boilerplate/blob/main/packages/sdk/package.json#L27- "@vue-storefront/middleware": "3.0.0-rc.2" => https://github.com/vuestorefront/integration-boilerplate/blob/main/packages/api-client/package.json#L20
- import from "@vue-storefront/middleware" in the test setup but the package is not provided in package.json as devDeps, test is failing! => https://github.com/vuestorefront/integration-boilerplate/blob/main/packages/sdk/__tests__/integration/__config__/jest.setup.global.ts#L1
Is there a specific reason to run rollup v2?
Updating all packages to the latest and running them against NodeJS v20
fails due to import { terser } from 'rollup-plugin-terser'; package... suggestion: updating to package import terser from '@rollup/plugin-terser'; solves the issue
update to rollup from v2 to v3: (to make it work)
- update all packages
- https://github.com/vuestorefront/integration-boilerplate/blob/main/rollup.base.config.js#L1
import nodeResolve from '@rollup/plugin-node-resolve';becomes =>import { nodeResolve } from '@rollup/plugin-node-resolve';(due to CJS - ESM module resolution error) - add
--bundleConfigAsCjsto all the npm scripts that use rollup- https://github.com/vuestorefront/integration-boilerplate/blob/main/packages/api-client/package.json#L14
- https://github.com/vuestorefront/integration-boilerplate/blob/main/packages/api-client/package.json#L15
- https://github.com/vuestorefront/integration-boilerplate/blob/main/packages/sdk/package.json#L11
- https://github.com/vuestorefront/integration-boilerplate/blob/main/packages/sdk/package.json#L12
Lerna:
After update to the latest version the useWorkspaces config is not needed (inferred from package.json which already has the workspaces setup done!) => https://github.com/vuestorefront/integration-boilerplate/blob/main/lerna.json#L2C4-L2C17
Missing stuff:
Add NCU and check and update package scripts
"update:check": "ncu && lerna run update:check --stream",
"update:update": "ncu -u && lerna run update:update --stream"Extra not needed deps?
What is the need for react and react-dom to be part of this boilerplate? https://github.com/vuestorefront/integration-boilerplate/blob/main/package.json#L47
Missing stuff from this boilerplate but that is added to the playground/app presume with a different template
playground/app/sdk.config.tsimportsimport { initSDK, buildModule } from '@vue-storefront/sdk';but the@vue-storefront/sdkpackage is not part of the package.json dependencies! (p.s don't know why it works with yarn tho, but not with npm)
Docs setup assumes you have yarn installed as it is hardcoded in the scripts, please change this one if you have already chosen to use npm as the package manager!
ref: https://github.com/vuestorefront/integration-boilerplate/blob/main/docs/package.json#L10
.husly is present in the boilerplate but husky package is not installed and prepare husky install script is missing!
.husky/commit-msg assumes commitlint is present, which is not!
ESLint present in the boilerplate repo but not installed (removed) when generating the integration?
p.s I might have missed something!
Additional information
- Would you be willing to help implement this feature?
- Could this feature be implemented as a module?
Final checks
- Read the contribution guide.
- Check existing discussions and issues.