Skip to content
This repository was archived by the owner on Jun 5, 2024. It is now read-only.
This repository was archived by the owner on Jun 5, 2024. It is now read-only.

Use ES6 target instead of ES5 #29

@adityasharma7

Description

@adityasharma7

Hi team,

First of all, kudos to you all for contributing such an amazing library.

I am using it in Ionic 5/ Angular apps to generate elastic search queries. I noticed the following warning when using it

[ng] Warning: /xxxx.ts depends on 'storefront-query-builder'. CommonJS or AMD dependencies can cause optimization bailouts.
[ng] For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

I think if we build it as ES6 modules instead of ES5, we have the advantage of having tree shaking which can help to reduce the JavaScript payload.

WDYAT?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions