-
-
Notifications
You must be signed in to change notification settings - Fork 870
feat[venom]: add multi-output instruction support for stack-based calling convention #4747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[venom]: add multi-output instruction support for stack-based calling convention #4747
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4747 +/- ##
==========================================
- Coverage 93.30% 93.28% -0.03%
==========================================
Files 137 137
Lines 19480 19623 +143
Branches 3367 3396 +29
==========================================
+ Hits 18176 18305 +129
- Misses 884 894 +10
- Partials 420 424 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vyper/venom/ir_node_to_venom.py
Outdated
| bb.append_instruction("ret", val, label) | ||
| ret_vals: list[IROperand] = [] | ||
| for i in range(k): | ||
| if i == 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this optimization is actually unnecessary right? will be handled by SCCP/algebraic opts
What I did
Extent Venom to support multi-output instructions and implemented a multi-output
invokefor functions that return multiple values.How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture