Address CodeRabbit review feedback

- Optimize CreateTab to avoid double workspace fetch (pass workspace to createTabObj)
- Remove paste scroll preservation (user wants auto-scroll to bottom on paste)
- Add constants for magic numbers in AI panel scroll (AUTO_SCROLL_DEBOUNCE_MS, SCROLL_BOTTOM_THRESHOLD_PX)
- Add passive event listener for better scroll performance
- Update comment in custom.d.ts to clarify getPathForFile implementation

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

Author: stevenvo

frontend/app/aipanel/aipanelmessages.tsx

@@ -8,6 +8,9 @@ import { AIModeDropdown } from "./aimode";
 import { type WaveUIMessage } from "./aitypes";
 import { WaveAIModel } from "./waveai-model";
 
+const AUTO_SCROLL_DEBOUNCE_MS = 100;
+const SCROLL_BOTTOM_THRESHOLD_PX = 50;
+
 interface AIPanelMessagesProps {
     messages: WaveUIMessage[];
     status: string;
@@ -32,7 +35,7 @@ export const AIPanelMessages = memo(({ messages, status, onContextMenu }: AIPane
             userHasScrolledUp.current = false;
             setTimeout(() => {
                 isAutoScrolling.current = false;
-            }, 100);
+            }, AUTO_SCROLL_DEBOUNCE_MS);
         }
     };
 
@@ -48,15 +51,15 @@ export const AIPanelMessages = memo(({ messages, status, onContextMenu }: AIPane
             const { scrollTop, scrollHeight, clientHeight } = container;
             const distanceFromBottom = scrollHeight - scrollTop - clientHeight;
 
-            // If user is more than 50px from the bottom, they've scrolled up
-            if (distanceFromBottom > 50) {
+            // If user is more than threshold from the bottom, they've scrolled up
+            if (distanceFromBottom > SCROLL_BOTTOM_THRESHOLD_PX) {
                 userHasScrolledUp.current = true;
             } else {
                 userHasScrolledUp.current = false;
             }
         };
 
-        container.addEventListener("scroll", handleScroll);
+        container.addEventListener("scroll", handleScroll, { passive: true });
         return () => container.removeEventListener("scroll", handleScroll);
     }, []);
 

frontend/app/view/term/termwrap.ts

@@ -830,9 +830,6 @@ export class TermWrap {
         e?.preventDefault();
         e?.stopPropagation();
 
-        // Preserve scroll position before paste
-        const scrollY = this.terminal.buffer.active.viewportY;
-
         try {
             const clipboardData = await extractAllClipboardData(e);
             let firstImage = true;
@@ -849,15 +846,6 @@ export class TermWrap {
                     this.terminal.paste(data.text);
                 }
             }
-
-            // Restore scroll position after paste if it changed unexpectedly
-            setTimeout(() => {
-                const currentScrollY = this.terminal.buffer.active.viewportY;
-                // Only restore if we've scrolled significantly (not just normal paste scroll)
-                if (currentScrollY < scrollY - 10) {
-                    this.terminal.scrollToLine(scrollY);
-                }
-            }, 50);
         } catch (err) {
             console.error("Paste error:", err);
         } finally {

frontend/types/custom.d.ts

@@ -130,7 +130,7 @@ declare global {
         openBuilder: (appId?: string) => void; // open-builder
         setBuilderWindowAppId: (appId: string) => void; // set-builder-window-appid
         doRefresh: () => void; // do-refresh
-        getPathForFile: (file: File) => string; // get-path-for-file
+        getPathForFile: (file: File) => string; // uses webUtils.getPathForFile
     };
 
     type ElectronContextMenuItem = {

pkg/wcore/workspace.go

@@ -228,7 +228,7 @@ func CreateTab(ctx context.Context, workspaceId string, tabName string, activate
 	}
 
 	// The initial tab for the initial launch should be pinned
-	tab, err := createTabObj(ctx, workspaceId, tabName, pinned || isInitialLaunch, inheritedMeta)
+	tab, err := createTabObjWithWorkspace(ctx, ws, tabName, pinned || isInitialLaunch, inheritedMeta)
 	if err != nil {
 		return "", fmt.Errorf("error creating tab: %w", err)
 	}
@@ -270,11 +270,8 @@ func CreateTab(ctx context.Context, workspaceId string, tabName string, activate
 	return tab.OID, nil
 }
 
-func createTabObj(ctx context.Context, workspaceId string, name string, pinned bool, meta waveobj.MetaMapType) (*waveobj.Tab, error) {
-	ws, err := GetWorkspace(ctx, workspaceId)
-	if err != nil {
-		return nil, fmt.Errorf("workspace %s not found: %w", workspaceId, err)
-	}
+// createTabObjWithWorkspace creates a tab object with an already-fetched workspace
+func createTabObjWithWorkspace(ctx context.Context, ws *waveobj.Workspace, name string, pinned bool, meta waveobj.MetaMapType) (*waveobj.Tab, error) {
 	layoutStateId := uuid.NewString()
 	tab := &waveobj.Tab{
 		OID:         uuid.NewString(),
@@ -297,6 +294,15 @@ func createTabObj(ctx context.Context, workspaceId string, name string, pinned b
 	return tab, nil
 }
 
+// createTabObj is a wrapper that fetches the workspace and calls createTabObjWithWorkspace
+func createTabObj(ctx context.Context, workspaceId string, name string, pinned bool, meta waveobj.MetaMapType) (*waveobj.Tab, error) {
+	ws, err := GetWorkspace(ctx, workspaceId)
+	if err != nil {
+		return nil, fmt.Errorf("workspace %s not found: %w", workspaceId, err)
+	}
+	return createTabObjWithWorkspace(ctx, ws, name, pinned, meta)
+}
+
 // Must delete all blocks individually first.
 // Also deletes LayoutState.
 // recursive: if true, will recursively close parent window, workspace, if they are empty.