-
Notifications
You must be signed in to change notification settings - Fork 525
update to gpt-5.1 #2552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to gpt-5.1 #2552
Conversation
WalkthroughThis pull request updates model references across the codebase from "gpt-5" to "gpt-5.1". Changes include updating the default model constant, context menu and description strings in the frontend, backend configuration constants, logic that checks or matches model names, and a log message. The updates span CLI, frontend UI components, and backend service packages without introducing new control flow or functionality. Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Areas requiring extra attention:
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pkg/waveai/openaibackend.go (1)
37-38: Optional: Redundant prefix check.Since
strings.HasPrefix(m, "gpt-5")already matches "gpt-5.1", the separate check on line 38 is redundant. The code is correct but could be simplified by removing line 38.return strings.HasPrefix(m, "o1") || strings.HasPrefix(m, "o3") || strings.HasPrefix(m, "o4") || - strings.HasPrefix(m, "gpt-5") || - strings.HasPrefix(m, "gpt-5.1") + strings.HasPrefix(m, "gpt-5")
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
cmd/testai/main-testai.go(1 hunks)frontend/app/aipanel/aipanel-contextmenu.ts(2 hunks)frontend/app/aipanel/thinkingmode.tsx(1 hunks)frontend/app/aipanel/waveai-model.tsx(1 hunks)pkg/aiusechat/openai/openai-convertmessage.go(1 hunks)pkg/aiusechat/uctypes/usechat-types.go(3 hunks)pkg/aiusechat/usechat.go(1 hunks)pkg/waveai/openaibackend.go(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-10-15T03:21:02.229Z
Learnt from: sawka
Repo: wavetermdev/waveterm PR: 2433
File: pkg/aiusechat/tools_readfile.go:197-197
Timestamp: 2025-10-15T03:21:02.229Z
Learning: In Wave Terminal's AI tool definitions (pkg/aiusechat/tools_*.go), the Description field should not mention approval requirements even when ToolApproval returns ApprovalNeedsApproval. This prevents the LLM from asking users for approval before calling the tool, avoiding redundant double-approval prompts since the runtime will enforce approval anyway.
Applied to files:
pkg/aiusechat/usechat.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Build for TestDriver.ai
- GitHub Check: Analyze (go)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (9)
frontend/app/aipanel/waveai-model.tsx (1)
83-83: LGTM! Default model updated to gpt-5.1.The fallback default for the model atom is correctly updated to "gpt-5.1", aligning with the premium model changes across the codebase.
cmd/testai/main-testai.go (1)
28-28: LGTM! Default test model updated.The default OpenAI model for testing is correctly updated to "gpt-5.1".
frontend/app/aipanel/thinkingmode.tsx (1)
28-28: LGTM! Thinking mode descriptions updated.The user-facing descriptions for "balanced" and "deep" thinking modes correctly reference "gpt-5.1" instead of "gpt-5", maintaining clarity for premium users.
Also applies to: 34-34
frontend/app/aipanel/aipanel-contextmenu.ts (1)
61-61: LGTM! Context menu labels updated.The context menu labels for thinking modes are correctly updated to reference "gpt-5.1" when premium is available, maintaining consistency with the thinking mode dropdown.
Also applies to: 74-74
pkg/aiusechat/openai/openai-convertmessage.go (1)
281-281: LGTM! Auto reasoning extended to gpt-5.1.The condition correctly extends auto reasoning summary support to both "gpt-5" and "gpt-5.1" models when thinking level is configured.
pkg/aiusechat/usechat.go (1)
478-478: LGTM! Log message updated.The premium rate limit log message correctly references "gpt-5.1" to reflect the current premium model.
pkg/aiusechat/uctypes/usechat-types.go (3)
15-15: LGTM! Premium model constant updated.The
PremiumOpenAIModelconstant is correctly updated to "gpt-5.1", establishing the new premium model across the codebase.
237-237: LGTM! Premium model check extended.The
IsPremiumModel()method correctly recognizes both "gpt-5" and "gpt-5.1" as premium models, maintaining backward compatibility while supporting the new version.
555-556: LGTM! Model compatibility updated.The
AreModelsCompatible()function correctly includes "gpt-5.1" in the gpt5Models set, ensuring proper compatibility checks when switching between gpt-5 family models.
No description provided.