Skip to content

Commit 6b5e9d4

Browse files
Clean Bitonic Sort sample (#543)
This PR cleans the Bitonic Sort sample by removing: - the unused stats UI - the "Chrome 121+" mention for timestamp queries since they are now implemented in Safari and Firefox.
1 parent 3dc7f9a commit 6b5e9d4

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

sample/bitonicSort/main.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { GUI } from 'dat.gui';
2-
import Stats from 'stats.js';
32
import { createBindGroupCluster, SampleInitFactoryWebGPU } from './utils';
43
import BitonicDisplayRenderer from './bitonicDisplay';
54
import { NaiveBitonicCompute } from './bitonicCompute';
@@ -632,8 +631,8 @@ SampleInitFactoryWebGPU(
632631
'Next Swap Span'
633632
);
634633

635-
// Timestamp information for Chrome 121+ or other compatible browsers
636-
const timestampFolder = gui.addFolder('Timestamp Info (Chrome 121+)');
634+
// Timestamp information
635+
const timestampFolder = gui.addFolder('Timestamp Info');
637636
const stepTimeController = timestampFolder.add(settings, 'Step Time');
638637
const sortTimeController = timestampFolder.add(settings, 'Sort Time');
639638
const averageSortTimeController = timestampFolder.add(
@@ -894,10 +893,7 @@ SampleInitFactoryWebGPU(
894893
}
895894
).then((init) => {
896895
const canvas = document.querySelector('canvas') as HTMLCanvasElement;
897-
const stats = new Stats();
898896
const gui = new GUI();
899897

900-
document.body.appendChild(stats.dom);
901-
902-
init({ canvas, stats, gui });
898+
init({ canvas, gui });
903899
});

sample/bitonicSort/utils.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ export type ShaderKeyInterface<T extends string[]> = {
9191
export type SampleInitParams = {
9292
canvas: HTMLCanvasElement;
9393
gui?: GUI;
94-
stats?: Stats;
9594
};
9695

9796
interface DeviceInitParms {
@@ -115,7 +114,7 @@ export type SampleInit = (params: SampleInitParams) => void;
115114
export const SampleInitFactoryWebGPU = async (
116115
callback: SampleInitCallback3D
117116
): Promise<SampleInit> => {
118-
const init = async ({ canvas, gui, stats }) => {
117+
const init = async ({ canvas, gui }) => {
119118
const adapter = await navigator.gpu?.requestAdapter({
120119
featureLevel: 'compatibility',
121120
});
@@ -150,7 +149,6 @@ export const SampleInitFactoryWebGPU = async (
150149
device,
151150
context,
152151
presentationFormat,
153-
stats,
154152
timestampQueryAvailable,
155153
});
156154
};

0 commit comments

Comments
 (0)