Skip to content

Conversation

@sam9525
Copy link

@sam9525 sam9525 commented May 28, 2025

Related issue: #681 Scroll to top when switching setting tabs

What I did

  1. Created an EventEmitter to monitor settings tab changes.
  2. Added ElementRef to the settings-modal class.
  3. Implemented a function to scroll the settings-modal to the top.

Thank you for maintaining this project and providing a beginner-friendly issue!

@whyboris
Copy link
Owner

😍 thank you so much! The code looks great (I've not run it yet but it looks like it should work great).

I'm hoping to get a new VHA release by end of summer; this PR will hang out until I start merging things, fixing bugs, and adding minor features. Thank you for your patience as I include this code sometime then 🙇‍♂️

Cheers 🥳

@sam9525
Copy link
Author

sam9525 commented Jun 13, 2025

Related issue: #857 Reduce empty space in details view above thumbnails

What I did

  1. Remove the fixed height from the details sheet.
  2. Remove the padding bottom from the view-tags-holder class.

I have addressed another issue #857 , but I submitted the commit in the same branch as the issue #681.
I would kindly like to inquire if this might cause any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants