Skip to content

iOS Devices: "restorePositionSetting" can run before "setPositionFixed" #247

@dafcoe

Description

@dafcoe

In some situations it can happen that "restorePositionSetting" runs before "setPositionFixed" when calling "enableBodyScroll" right after "enableBodyScroll" and therefore the scroll lock is not being released due to fixed positioning on target element.

Example: https://codesandbox.io/s/wizardly-sound-53xgy

Possible fix: by wrapping restorePositionSetting logic on a requestAnimationFrame method queues the execution and prevent this issue to happen since setPositionFixed is already using requestAnimationFrame. Created a pull request with this change.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions