refactor: rewrite trait Entity and friends so searching is reasonable [WPB-20839]
#1633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable the `derive(Entity)` macro to a noop. I'm going to be doing some major refactoring of the `Entity` trait, and the noise of compiler errors due to implementations not matching the new definitions would absolutely drown out the signal of real problems, except for this. Obviously, we need to retain a real entity derive macro before this PR is over, but this should simplify things temporarily.
These traits should be both easier to use and more performant.
istankovic
reviewed
Dec 1, 2025
| } | ||
|
|
||
| // About WASM Encryption: | ||
| // The store key (i.e. passphrase) is hashed using SHA256 to obtain 32 bytes |
Member
There was a problem hiding this comment.
This is not the case anymore, since the database key type change clients have to provide the key directly .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.