Skip to content

feat(stack): implement control flow and checktimelock #2217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

feat(stack): implement control flow and checktimelock #2217

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
78aab3f
feat(stack): implement control flow
tmpolaczyk Jun 7, 2022
65e183e
feat(stack): allow context in machine operate function
tmpolaczyk Jun 8, 2022
c301938
feat: implement CheckTimelock scripting operator
tmpolaczyk Jun 8, 2022
7057d7f
feat(stack): Sha256 operator
tmpolaczyk Jun 8, 2022
81eb69a
feat: add error handling to script encode and decode
tmpolaczyk Jun 8, 2022
85dc1dd
feat(node): avoid unused call to signature_mngr in BuildScriptTx
tmpolaczyk Jun 13, 2022
9eb710e
feat(stack): remove MyControlFlow enum, use simple Result instead
tmpolaczyk Jun 13, 2022
0ff9da4
feat(stack): implement CheckSig operator
tmpolaczyk Jun 14, 2022
c96a82e
test(stack): add atomic swap use case test
tmpolaczyk Jun 15, 2022
b557090
test(stack): add another atomic swap test case
tmpolaczyk Jun 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
118 changes: 118 additions & 0 deletions stack/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -872,4 +872,122 @@ mod tests {
}
));
}

#[test]
fn test_execute_script_atomic_swap() {
let secret = vec![1, 2, 3, 4];
let hash_secret = calculate_sha256(&secret);
let pk_1 = PublicKey::from_bytes([1; 33]);
let pk_2 = PublicKey::from_bytes([2; 33]);

let ks_1 = ks_from_pk(pk_1.clone());
let ks_2 = ks_from_pk(pk_2.clone());

// 1 can spend after timelock
let s = vec![
// Witness script
Item::Value(MyValue::Signature(ks_1.to_pb_bytes().unwrap())),
Item::Value(MyValue::Boolean(true)),
// Redeem script
Item::Operator(MyOperator::If),
Item::Value(MyValue::Integer(10_000)),
Item::Operator(MyOperator::CheckTimeLock),
Item::Operator(MyOperator::Verify),
Item::Value(MyValue::Bytes(pk_1.pkh().bytes().to_vec())),
Item::Operator(MyOperator::CheckSig),
Item::Operator(MyOperator::Verify),
Item::Operator(MyOperator::Else),
Item::Operator(MyOperator::Sha256),
Item::Value(MyValue::Bytes(hash_secret.as_ref().to_vec())),
Item::Operator(MyOperator::Equal),
Item::Operator(MyOperator::Verify),
Item::Value(MyValue::Bytes(pk_2.pkh().bytes().to_vec())),
Item::Operator(MyOperator::CheckSig),
Item::Operator(MyOperator::Verify),
Item::Operator(MyOperator::EndIf),
];
assert!(execute_script(
s,
&ScriptContext {
block_timestamp: 20_000
}
));

// 1 cannot spend before timelock
let s = vec![
// Witness script
Item::Value(MyValue::Signature(ks_1.to_pb_bytes().unwrap())),
Item::Value(MyValue::Boolean(true)),
// Redeem script
Item::Operator(MyOperator::If),
Item::Value(MyValue::Integer(10_000)),
Item::Operator(MyOperator::CheckTimeLock),
Item::Operator(MyOperator::Verify),
Item::Value(MyValue::Bytes(pk_1.pkh().bytes().to_vec())),
Item::Operator(MyOperator::CheckSig),
Item::Operator(MyOperator::Verify),
Item::Operator(MyOperator::Else),
Item::Operator(MyOperator::Sha256),
Item::Value(MyValue::Bytes(hash_secret.as_ref().to_vec())),
Item::Operator(MyOperator::Equal),
Item::Operator(MyOperator::Verify),
Item::Value(MyValue::Bytes(pk_2.pkh().bytes().to_vec())),
Item::Operator(MyOperator::CheckSig),
Item::Operator(MyOperator::Verify),
Item::Operator(MyOperator::EndIf),
];
assert!(!execute_script(s, &ScriptContext { block_timestamp: 0 }));

// 2 can spend with secret
let s = vec![
// Witness script
Item::Value(MyValue::Signature(ks_2.to_pb_bytes().unwrap())),
Item::Value(MyValue::Bytes(secret)),
Item::Value(MyValue::Boolean(false)),
// Redeem script
Item::Operator(MyOperator::If),
Item::Value(MyValue::Integer(10_000)),
Item::Operator(MyOperator::CheckTimeLock),
Item::Operator(MyOperator::Verify),
Item::Value(MyValue::Bytes(pk_1.pkh().bytes().to_vec())),
Item::Operator(MyOperator::CheckSig),
Item::Operator(MyOperator::Verify),
Item::Operator(MyOperator::Else),
Item::Operator(MyOperator::Sha256),
Item::Value(MyValue::Bytes(hash_secret.as_ref().to_vec())),
Item::Operator(MyOperator::Equal),
Item::Operator(MyOperator::Verify),
Item::Value(MyValue::Bytes(pk_2.pkh().bytes().to_vec())),
Item::Operator(MyOperator::CheckSig),
Item::Operator(MyOperator::Verify),
Item::Operator(MyOperator::EndIf),
];
assert!(execute_script(s, &ScriptContext { block_timestamp: 0 }));

// 2 cannot spend with a wrong secret
let s = vec![
// Witness script
Item::Value(MyValue::Signature(ks_2.to_pb_bytes().unwrap())),
Item::Value(MyValue::Bytes(vec![0, 0, 0, 0])),
Item::Value(MyValue::Boolean(false)),
// Redeem script
Item::Operator(MyOperator::If),
Item::Value(MyValue::Integer(10_000)),
Item::Operator(MyOperator::CheckTimeLock),
Item::Operator(MyOperator::Verify),
Item::Value(MyValue::Bytes(pk_1.pkh().bytes().to_vec())),
Item::Operator(MyOperator::CheckSig),
Item::Operator(MyOperator::Verify),
Item::Operator(MyOperator::Else),
Item::Operator(MyOperator::Sha256),
Item::Value(MyValue::Bytes(hash_secret.as_ref().to_vec())),
Item::Operator(MyOperator::Equal),
Item::Operator(MyOperator::Verify),
Item::Value(MyValue::Bytes(pk_2.pkh().bytes().to_vec())),
Item::Operator(MyOperator::CheckSig),
Item::Operator(MyOperator::Verify),
Item::Operator(MyOperator::EndIf),
];
assert!(!execute_script(s, &ScriptContext { block_timestamp: 0 }));
}
Comment on lines +942 to +993
Copy link
Member

@aesedepece aesedepece Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we check that 2 cannot spend after timelock even if the right secret is provided? 🤔

Copy link
Contributor Author

@tmpolaczyk tmpolaczyk Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this script they can, if that's a requirement we can add another test for that case.

Copy link
Member

@aesedepece aesedepece Jun 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that, ideally, they shouldn't. It is a sort of assumption for an atomic swap that only 1 party can spend at a time.

}