Skip to content

error when CORNER_LOCATION_NONE and corner_radius != 0 #137

@the-eater

Description

@the-eater

if (clipped_region.corner_radius && clipped_region.corners == CORNER_LOCATION_NONE) {
wlr_log(WLR_ERROR, "Applying corner radius without specifying which"
" corners to round for rect: %p", rect);
}

Currently it logs an error if location is none and corner_radius != 0.

But how much of an issue is this? would it make sense to set corner_radius to 0 in this function instead of logging of an error?

I am mostly hitting this issue in WillPower3309/swayfx#456

where I use a bitmask to only enable the corners that are applicable. and repeating (value & mask) != CORNER_LOCATION_NONE ? corner_radius : 0 feels like a bit much

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions