chore: Linter compliances met

kidunot89 · kidunot89 · commit 7048671545b6 · 2025-11-14T13:08:56.000-05:00
diff --git a/composer.lock b/composer.lock
diff --git a/includes/class-core-schema-filters.php b/includes/class-core-schema-filters.php
@@ -11,8 +11,8 @@
 use GraphQL\Error\UserError;
 use WPGraphQL\WooCommerce\Data\Factory;
 use WPGraphQL\WooCommerce\Data\Loader\WC_CPT_Loader;
-use WPGraphQL\WooCommerce\Data\Loader\WC_Customer_Loader;
 use WPGraphQL\WooCommerce\Data\Loader\WC_Cart_Item_Loader;
+use WPGraphQL\WooCommerce\Data\Loader\WC_Customer_Loader;
 use WPGraphQL\WooCommerce\Data\Loader\WC_Downloadable_Item_Loader;
 use WPGraphQL\WooCommerce\Data\Loader\WC_Order_Item_Loader;
 use WPGraphQL\WooCommerce\Data\Loader\WC_Shipping_Method_Loader;
@@ -39,7 +39,7 @@ public static function add_filters() {
 		add_filter( 'register_taxonomy_args', [ self::class, 'register_taxonomy_args' ], 10, 2 );
 
 		// Add data-loaders to AppContext.
-		add_filter( 'graphql_data_loader_classes', [ self::class, 'graphql_data_loader_classes' ], 10, 2 );
+		add_filter( 'graphql_data_loader_classes', [ self::class, 'graphql_data_loader_classes' ], 10 );
 
 		// Add node resolvers.
 		add_filter(
@@ -272,8 +272,7 @@ public static function register_taxonomy_args( $args, $taxonomy ) {
 	/**
 	 * Registers data-loaders to be used when resolving WooCommerce-related GraphQL types
 	 *
-	 * @param array                 $loaders - assigned loaders.
-	 * @param \WPGraphQL\AppContext $context - AppContext instance.
+	 * @param array $loaders  Assigned loaders.
 	 *
 	 * @return array
 	 */
@@ -409,6 +408,7 @@ public static function resolve_product_type( $value ) {
 		} elseif ( $value instanceof \WPGraphQL\Model\Post && ( 'product' !== $value->post_type && 'product_variation' !== $value->post_type ) ) {
 			throw new UserError(
 				sprintf(
+					/* translators: %s: Post type slug */
 					__( 'The "%s" post type is not a valid product type.', 'wp-graphql-woocommerce' ),
 					$value->post_type
 				)
@@ -417,7 +417,7 @@ public static function resolve_product_type( $value ) {
 			$product_model = $value;
 		}
 
-		$product_type   = $product_model->get_type();
+		$product_type = $product_model->get_type();
 		if ( isset( $possible_types[ $product_type ] ) ) {
 			return $type_registry->get_type( $possible_types[ $product_type ] );
 		} elseif ( $product_model instanceof \WPGraphQL\WooCommerce\Model\Product_Variation ) {
@@ -482,8 +482,8 @@ public static function make_order_notes_visible( $is_private, $model_name, $data
 		if ( $data instanceof \WP_Comment && 'order_note' === $data->comment_type ) {
 			// Get the parent order.
 			$order_id = absint( $data->comment_post_ID );
-			$order = wc_get_order( $order_id );
-			
+			$order    = wc_get_order( $order_id );
+
 			if ( ! $order ) {
 				return true; // Keep it private if order not found.
 			}
@@ -494,9 +494,14 @@ public static function make_order_notes_visible( $is_private, $model_name, $data
 			}
 
 			// Allow customers to see customer notes on their own orders.
-			$is_customer_note = get_comment_meta( $data->comment_ID, 'is_customer_note', true );
-			if ( $is_customer_note && get_current_user_id() === $order->get_customer_id() ) {
-				return false; // Not private.
+			$comment_id = absint( $data->comment_ID );
+			$is_customer_note = get_comment_meta( $comment_id, 'is_customer_note', true );
+			if ( $is_customer_note && ! is_bool( $order ) && is_a( $order, \WC_Order::class ) ) {
+				if ( get_current_user_id() === $order->get_customer_id() ) return false; // Not private.
+			} elseif ( $is_customer_note && ! is_bool( $order ) && is_a( $order, \WC_Order_Refund::class ) ) {
+				/** @var \WC_Order|false $parent */
+				$parent = wc_get_order( $order->get_parent_id() );
+				if ( $parent && get_current_user_id() === $parent->get_customer_id() ) return false; // Not private.
 			}
 
 			// Otherwise keep it private.
@@ -509,11 +514,11 @@ public static function make_order_notes_visible( $is_private, $model_name, $data
 	/**
 	 * Filter to set order notes visibility to public for authorized users.
 	 *
-	 * @param string     $visibility   The visibility of the object.
-	 * @param string     $model_name   The name of the model being checked.
-	 * @param mixed      $data         The data being checked.
-	 * @param int|null   $owner        The owner of the object.
-	 * @param \WP_User   $current_user The current user.
+	 * @param string   $visibility   The visibility of the object.
+	 * @param string   $model_name   The name of the model being checked.
+	 * @param mixed    $data         The data being checked.
+	 * @param int|null $owner        The owner of the object.
+	 * @param \WP_User $current_user The current user.
 	 *
 	 * @return string
 	 */
@@ -526,10 +531,14 @@ public static function set_order_notes_visibility( $visibility, $model_name, $da
 		// Check if this is an order note and if user owns the order.
 		if ( $data instanceof \WP_Comment && 'order_note' === $data->comment_type ) {
 			$order = wc_get_order( $data->comment_post_ID );
-			
+
 			// If user is the order owner, make it public.
-			if ( $order && get_current_user_id() === $order->get_customer_id() ) {
-				return 'public';
+			if ( $order && ! is_bool( $order ) && is_a( $order, \WC_Order::class ) ) {
+				return get_current_user_id() === $order->get_customer_id() ? 'public' : $visibility;
+			} else if ( $order && ! is_bool( $order ) && is_a( $order, \WC_Order_Refund::class ) ) {
+				/** @var \WC_Order|false $parent */
+				$parent = wc_get_order( $order->get_parent_id() );
+				return $parent && get_current_user_id() === $parent->get_customer_id() ? 'public' : $visibility;
 			}
 		}
 
diff --git a/includes/data/connection/class-product-connection-resolver.php b/includes/data/connection/class-product-connection-resolver.php
@@ -491,7 +491,7 @@ public function sanitize_input_fields( array $where_args ) {
 						$term_taxonomy_ids = [];
 						foreach ( $terms as $term_slug ) {
 							$term = get_term_by( 'slug', $term_slug, $taxonomy );
-							if ( ! $term || is_wp_error( $term ) ) {
+							if ( ! $term ) {
 								continue;
 							}
 							$term_taxonomy_ids[] = $term->term_taxonomy_id;
diff --git a/includes/data/loader/class-wc-cart-item-loader.php b/includes/data/loader/class-wc-cart-item-loader.php
@@ -14,12 +14,12 @@
  * Class WC_Cart_Item_Loader
  */
 class WC_Cart_Item_Loader extends WC_Db_Loader {
-    /**
+	/**
 	 * WC_Cart_Item_Loader constructor
 	 *
 	 * @param \WPGraphQL\AppContext $context AppContext instance.
 	 */
-    public function __construct( $context ) {
-        parent::__construct( $context, 'CART_ITEM' );
-    }
-}
+	public function __construct( $context ) {
+		parent::__construct( $context, 'CART_ITEM' );
+	}
+}
diff --git a/includes/data/loader/class-wc-downloadable-item-loader.php b/includes/data/loader/class-wc-downloadable-item-loader.php
@@ -14,12 +14,12 @@
  * Class WC_Downloadable_Item_Loader
  */
 class WC_Downloadable_Item_Loader extends WC_Db_Loader {
-    /**
+	/**
 	 * WC_Downloadable_Item_Loader constructor
 	 *
 	 * @param \WPGraphQL\AppContext $context AppContext instance.
 	 */
-    public function __construct( $context ) {
-        parent::__construct( $context, 'DOWNLOADABLE_ITEM' );
-    }
-}
+	public function __construct( $context ) {
+		parent::__construct( $context, 'DOWNLOADABLE_ITEM' );
+	}
+}
diff --git a/includes/data/loader/class-wc-order-item-loader.php b/includes/data/loader/class-wc-order-item-loader.php
@@ -14,12 +14,12 @@
  * Class WC_Order_Item_Loader
  */
 class WC_Order_Item_Loader extends WC_Db_Loader {
-    /**
+	/**
 	 * WC_Order_Item_Loader constructor
 	 *
 	 * @param \WPGraphQL\AppContext $context AppContext instance.
 	 */
-    public function __construct( $context ) {
-        parent::__construct( $context, 'ORDER_ITEM' );
-    }
-}
+	public function __construct( $context ) {
+		parent::__construct( $context, 'ORDER_ITEM' );
+	}
+}
diff --git a/includes/data/loader/class-wc-shipping-method-loader.php b/includes/data/loader/class-wc-shipping-method-loader.php
@@ -14,12 +14,12 @@
  * Class WC_Shipping_Method_Loader
  */
 class WC_Shipping_Method_Loader extends WC_Db_Loader {
-    /**
+	/**
 	 * WC_Shipping_Method_Loader constructor
 	 *
 	 * @param \WPGraphQL\AppContext $context      AppContext instance.
 	 */
-    public function __construct( $context ) {
-        parent::__construct( $context, 'SHIPPING_METHOD' );
-    }
-}
+	public function __construct( $context ) {
+		parent::__construct( $context, 'SHIPPING_METHOD' );
+	}
+}
diff --git a/includes/data/loader/class-wc-shipping-zone-loader.php b/includes/data/loader/class-wc-shipping-zone-loader.php
@@ -14,12 +14,12 @@
  * Class WC_Shipping_Zone_Loader
  */
 class WC_Shipping_Zone_Loader extends WC_Db_Loader {
-    /**
+	/**
 	 * WC_Shipping_Zone_Loader constructor
 	 *
 	 * @param \WPGraphQL\AppContext $context      AppContext instance.
 	 */
-    public function __construct( $context ) {
-        parent::__construct( $context, 'SHIPPING_ZONE' );
-    }
-}
+	public function __construct( $context ) {
+		parent::__construct( $context, 'SHIPPING_ZONE' );
+	}
+}
diff --git a/includes/data/loader/class-wc-tax-class-loader.php b/includes/data/loader/class-wc-tax-class-loader.php
@@ -14,12 +14,12 @@
  * Class WC_Tax_Class_Loader
  */
 class WC_Tax_Class_Loader extends WC_Db_Loader {
-    /**
+	/**
 	 * WC_Tax_Class_Loader constructor
 	 *
 	 * @param \WPGraphQL\AppContext $context AppContext instance.
 	 */
-    public function __construct( $context ) {
-        parent::__construct( $context, 'TAX_CLASS' );
-    }
-}
+	public function __construct( $context ) {
+		parent::__construct( $context, 'TAX_CLASS' );
+	}
+}
diff --git a/includes/data/loader/class-wc-tax-rate-loader.php b/includes/data/loader/class-wc-tax-rate-loader.php
@@ -14,12 +14,12 @@
  * Class WC_Tax_Rate_Loader
  */
 class WC_Tax_Rate_Loader extends WC_Db_Loader {
-    /**
+	/**
 	 * WC_Tax_Rate_Loader constructor
 	 *
 	 * @param \WPGraphQL\AppContext $context AppContext instance.
 	 */
-    public function __construct( $context ) {
-        parent::__construct( $context, 'TAX_RATE' );
-    }
-}
+	public function __construct( $context ) {
+		parent::__construct( $context, 'TAX_RATE' );
+	}
+}
diff --git a/includes/mutation/class-order-note-create.php b/includes/mutation/class-order-note-create.php
@@ -13,8 +13,8 @@
 use GraphQL\Error\UserError;
 use GraphQL\Type\Definition\ResolveInfo;
 use WPGraphQL\AppContext;
-use WPGraphQL\Utils\Utils;
 use WPGraphQL\Model\Comment;
+use WPGraphQL\Utils\Utils;
 use WPGraphQL\WooCommerce\Data\Mutation\Order_Mutation;
 use WPGraphQL\WooCommerce\Model\Order;
 
diff --git a/includes/mutation/class-order-note-delete.php b/includes/mutation/class-order-note-delete.php
@@ -13,8 +13,8 @@
 use GraphQL\Error\UserError;
 use GraphQL\Type\Definition\ResolveInfo;
 use WPGraphQL\AppContext;
-use WPGraphQL\Utils\Utils;
 use WPGraphQL\Model\Comment;
+use WPGraphQL\Utils\Utils;
 use WPGraphQL\WooCommerce\Data\Mutation\Order_Mutation;
 use WPGraphQL\WooCommerce\Model\Order;
 
@@ -127,7 +127,8 @@ public static function mutate_and_get_payload() {
 				throw new UserError( __( 'Invalid resource ID.', 'wp-graphql-woocommerce' ) );
 			}
 
-			$result = wc_delete_order_note( $note->comment_ID );
+			$comment_id = absint( $note->comment_ID );
+			$result = wc_delete_order_note( $comment_id );
 
 			if ( ! $result ) {
 				throw new UserError( __( 'Unable to delete order note.', 'wp-graphql-woocommerce' ) );
diff --git a/includes/mutation/class-review-delete-restore.php b/includes/mutation/class-review-delete-restore.php
@@ -136,7 +136,7 @@ public static function mutate_and_get_payload() {
 				throw new UserError( __( 'Invalid Product Review ID provided', 'wp-graphql-woocommerce' ) );
 			}
 
-			$rating = get_comment_meta( absint( $id ), 'rating' );
+			$rating = get_comment_meta( absint( $id ), 'rating', true );
 
 			// @codingStandardsIgnoreLine
 			switch ( $info->fieldName ) {
diff --git a/includes/type/object/class-collection-stats-type.php b/includes/type/object/class-collection-stats-type.php
@@ -334,7 +334,7 @@ public static function prepare_rest_request( array $where_args = [] ) {
 			$category_ids = array_map(
 				static function ( $category ) {
 					$term = get_term_by( 'slug', $category, 'product_cat' );
-					if ( $term && ! is_wp_error( $term ) ) {
+					if ( $term ) {
 						return $term->term_id;
 					}
 					return 0;
@@ -354,7 +354,7 @@ static function ( $category ) {
 			$tag_ids = array_map(
 				static function ( $tag ) {
 					$term = get_term_by( 'slug', $tag, 'product_tag' );
-					if ( $term && ! is_wp_error( $term ) ) {
+					if ( $term ) {
 						return $term->term_id;
 					}
 					return 0;
diff --git a/includes/type/object/class-order-note-type.php b/includes/type/object/class-order-note-type.php
@@ -25,7 +25,7 @@ public static function register() {
 		register_graphql_object_type(
 			'OrderNote',
 			[
-				'interfaces'      => ['Node'],
+				'interfaces'      => [ 'Node' ],
 				'eagerlyLoadType' => true,
 				'description'     => __( 'A order note', 'wp-graphql-woocommerce' ),
 				'fields'          => apply_filters( 'woographql_order_note_field_definitions', self::get_fields() ),
@@ -43,7 +43,7 @@ public static function get_fields( $other_fields = [] ) {
 		return array_merge(
 			[
 				'id'             => [
-					'type'        => ['non_null' => 'ID'],
+					'type'        => [ 'non_null' => 'ID' ],
 					'description' => __( 'Database ID or global ID of the order note', 'wp-graphql-woocommerce' ),
 					'resolve'     => static function ( $order_note ) {
 						return Relay::toGlobalId( 'order_note', $order_note->databaseId );

Original file line number	Diff line number	Diff line change
`@@ -491,7 +491,7 @@ public function sanitize_input_fields( array $where_args ) {`
`491`	`491`	`$term_taxonomy_ids = [];`
`492`	`492`	`foreach ( $terms as $term_slug ) {`
`493`	`493`	`$term = get_term_by( 'slug', $term_slug, $taxonomy );`
`494`		`- if ( ! $term \|\| is_wp_error( $term ) ) {`
	`494`	`+ if ( ! $term ) {`
`495`	`495`	`continue;`
`496`	`496`	`}`
`497`	`497`	`$term_taxonomy_ids[] = $term->term_taxonomy_id;`