Fixes publishing archives (#6905)

## What's the problem this PR addresses?

We shipped a change that had the unfortunate effect of breaking
publishing packages. It somehow didn't break our tests, which is
something we'll have to investigate. In the meantime I want to fix it
quick.

## How did you fix it?

Revert the probable cause; it wasn't a very important change, and I
found another to achieve what we intended to do.

## Checklist

<!--- Don't worry if you miss something, chores are automatically
tested. -->
<!--- This checklist exists to help you remember doing the chores when
you submit a PR. -->
<!--- Put an `x` in all the boxes that apply. -->
- [x] I have read the [Contributing
Guide](https://yarnpkg.com/advanced/contributing).

<!-- See
https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released
for more details. -->
<!-- Check with `yarn version check` and fix with `yarn version check
-i` -->
- [x] I have set the packages that need to be released for my changes to
be effective.

<!-- The "Testing chores" workflow validates that your PR follows our
guidelines. -->
<!-- If it doesn't pass, click on it to see details as to what your PR
might be missing. -->
- [x] I will check that all automated PR checks pass before the PR gets
reviewed.

Author: arcanis

.yarn/versions/65c28eb2.yml

@@ -0,0 +1,25 @@
+releases:
+  "@yarnpkg/cli": patch
+  "@yarnpkg/plugin-pack": patch
+
+declined:
+  - "@yarnpkg/plugin-catalog"
+  - "@yarnpkg/plugin-compat"
+  - "@yarnpkg/plugin-constraints"
+  - "@yarnpkg/plugin-dlx"
+  - "@yarnpkg/plugin-essentials"
+  - "@yarnpkg/plugin-init"
+  - "@yarnpkg/plugin-interactive-tools"
+  - "@yarnpkg/plugin-nm"
+  - "@yarnpkg/plugin-npm"
+  - "@yarnpkg/plugin-npm-cli"
+  - "@yarnpkg/plugin-patch"
+  - "@yarnpkg/plugin-pnp"
+  - "@yarnpkg/plugin-pnpm"
+  - "@yarnpkg/plugin-stage"
+  - "@yarnpkg/plugin-typescript"
+  - "@yarnpkg/plugin-version"
+  - "@yarnpkg/plugin-workspace-tools"
+  - "@yarnpkg/builder"
+  - "@yarnpkg/core"
+  - "@yarnpkg/doctor"

packages/plugin-pack/sources/packUtils.ts

@@ -79,63 +79,61 @@ export async function genPackStream(workspace: Workspace, files?: Array<Portable
 
   const pack = tar.pack();
 
-  // I don't recall why this was necessary, but probably something to do
-  // with how Node.js streams process their events vs their drains.
-  await new Promise(process.nextTick);
+  process.nextTick(async () => {
+    for (const fileRequest of files!) {
+      const file = ppath.normalize(fileRequest);
 
-  for (const fileRequest of files!) {
-    const file = ppath.normalize(fileRequest);
+      const source = ppath.resolve(workspace.cwd, file);
+      const dest = ppath.join(`package`, file);
 
-    const source = ppath.resolve(workspace.cwd, file);
-    const dest = ppath.join(`package`, file);
+      const stat = await xfs.lstatPromise(source);
 
-    const stat = await xfs.lstatPromise(source);
+      const opts = {
+        name: dest,
+        mtime: new Date(constants.SAFE_TIME * 1000),
+      };
 
-    const opts = {
-      name: dest,
-      mtime: new Date(constants.SAFE_TIME * 1000),
-    };
+      const mode = executableFiles.has(file)
+        ? 0o755
+        : 0o644;
 
-    const mode = executableFiles.has(file)
-      ? 0o755
-      : 0o644;
+      let resolveFn: Function;
+      let rejectFn: Function;
 
-    let resolveFn: Function;
-    let rejectFn: Function;
+      const awaitTarget = new Promise((resolve, reject) => {
+        resolveFn = resolve;
+        rejectFn = reject;
+      });
 
-    const awaitTarget = new Promise((resolve, reject) => {
-      resolveFn = resolve;
-      rejectFn = reject;
-    });
+      const cb = (error: any) => {
+        if (error) {
+          rejectFn(error);
+        } else {
+          resolveFn();
+        }
+      };
 
-    const cb = (error: any) => {
-      if (error) {
-        rejectFn(error);
-      } else {
-        resolveFn();
-      }
-    };
+      if (stat.isFile()) {
+        let content: Buffer;
 
-    if (stat.isFile()) {
-      let content: Buffer;
+        // The root package.json supports replacement fields in publishConfig
+        if (file === `package.json`)
+          content = Buffer.from(JSON.stringify(await genPackageManifest(workspace), null, 2));
+        else
+          content = await xfs.readFilePromise(source);
 
-      // The root package.json supports replacement fields in publishConfig
-      if (file === `package.json`)
-        content = Buffer.from(JSON.stringify(await genPackageManifest(workspace), null, 2));
-      else
-        content = await xfs.readFilePromise(source);
+        pack.entry({...opts, mode, type: `file`}, content, cb);
+      } else if (stat.isSymbolicLink()) {
+        pack.entry({...opts, mode, type: `symlink`, linkname: await xfs.readlinkPromise(source)}, cb);
+      } else {
+        cb(new Error(`Unsupported file type ${stat.mode} for ${npath.fromPortablePath(file)}`));
+      }
 
-      pack.entry({...opts, mode, type: `file`}, content, cb);
-    } else if (stat.isSymbolicLink()) {
-      pack.entry({...opts, mode, type: `symlink`, linkname: await xfs.readlinkPromise(source)}, cb);
-    } else {
-      cb(new Error(`Unsupported file type ${stat.mode} for ${npath.fromPortablePath(file)}`));
+      await awaitTarget;
     }
 
-    await awaitTarget;
-  }
-
-  pack.finalize();
+    pack.finalize();
+  });
 
   const tgz = createGzip();
   pack.pipe(tgz);