Subset alternation #116
Open
Subset alternation #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
archaephyrryx
force-pushed
the
subset_alternation
branch
from
de87494 to
a7b755c
Compare
archaephyrryx
commented
Nov 15, 2023
| Format::RepeatFallback(_narrow, _wide) => match value { | ||
| Value::Seq(values) => { | ||
| for _v in values { | ||
| (); // FIXME |
Contributor
Author
There was a problem hiding this comment.
I am slightly unclear on the semantics of check_covered, and so I am not sure how to implement this...
archaephyrryx
force-pushed
the
subset_alternation
branch
from
557d9a6 to
dd6c623
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
RepeatFallbackand related helper-variants to Decoder, Format, and Value.There is a strong possibility this is misimplemented somewhere due to knock-on effect of failure-tracing to different sites, which may have left things in a partially-implemented or hold-over state.