feat!: update injector to respect arch of package #4405
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Signed-off-by: Allen Conlon <[email protected]>
a1994sc
force-pushed
the
feature/allen/node-arch
branch
from
68fdec5 to
b5f89b1
Compare
|
This PR does also include a new workflow, provided by Austin, to test some level of multi-arch workflows. |
a1994sc
changed the title
brandtkeller
left a comment
brandtkeller
left a comment
There was a problem hiding this comment.
Passing comment for thoughts and opinions.
src/pkg/cluster/injector.go
Outdated
| var zarfImageRegex = regexp.MustCompile(`(?m)^(127\.0\.0\.1|\[::1\]):`) | ||
|
|
||
| // InjectorOpts represents the config for the injector pod | ||
| type InjectorOpts struct { |
There was a problem hiding this comment.
Layout of the structure looks good. Quick passing thought of ensuring these items are indeed optional?
Ideally required items are function parameters and optional are in the options struct.
Another overlay may be deciding if we can set sane defaults.
There was a problem hiding this comment.
Hm, gotcha, I think that makes sense too me... I will have to look up some examples on how to enforce certain fields are populated verses optional...
Thank you Brandt!
(P.S. If you have a more meaningful name for this struct feel free to drop it, I'm crap at naming stuff)
Signed-off-by: Allen Conlon <[email protected]>
Signed-off-by: Allen Conlon <[email protected]>
2 participants
Description
This is PR adds checks during the scheduling of the injector pod to match the architecture of the package; e.i. if you have an
amd64zarf init package, then the injector will only be scheduled on a node ofamd64.A chunk of the work for this PR came from PR #3935 but I felt it was better to focus on the injector part in this PR and open a second PR for scheduling the agent/registry.
Related Issue
Relates to #3817
Checklist before merging