[SOLVED]Linker error with Webrtc on Windows

[xulai1001]

Summary

Linking zed.exe in windows failed with error: rust-lld: error: /failifmismatch: mismatch detected for 'RuntimeLibrary'

Description

rust-lld: error: /failifmismatch: mismatch detected for 'RuntimeLibrary':␍
          >>> libwebrtc_sys-35b9de37ab8692ab.rlib(0602fb52cb66f316-media_stream_track.o) has value MD_DynamicRelease␍
          >>> libwebrtc_sys-35b9de37ab8692ab.rlib(video_frame.obj) has value MT_StaticRelease␍

Steps to reproduce:

1. Build zed root project with cargo build --release on Windows 11 x64
2. The build step was successful ( with MSVC 143 Spectre migitation libs installed to prevent previous issues), but linking failed with such error.
3. Using msvc link.exe to link (not rust-lld) also exited with the error above.

Expected result:
All parts of libwebrtc_sys should set to statically linked.

Other tries:
I have tried to upgrade the libwebrtc dependency in livekit_client/Cargo.toml to the latest version ( 0.3.11 ), but Zed failed to compile due to breaking changes in libwebrtc version 0.3.8.

Zed Version and System Specs

latest version of master branch

[xulai1001]

Any measure to force static linking?

error: linking with `rust-lld` failed: exit code: 1
  |
  = note: "rust-lld" "-flavor" "link" "/NOLOGO" "C:\\Users\\Curran\\AppData\\Local\\Temp\\rustcHmjRG6\\symbols.o" "<946 object files omitted>" "<rlib and LIBPATH omitted>" "/OUT:E:\\src\\zed\\target\\release\\deps\\zed.exe" 
"/SUBSYSTEM:windows" 
"/ENTRY:mainCRTStartup" 
"/OPT:REF,ICF" "/DEBUG" 
"/PDBALTPATH:%_PDB%" 
"/NATVIS:<sysroot>\\lib\\rustlib\\etc\\intrinsic.natvis" 
"/NATVIS:<sysroot>\\lib\\rustlib\\etc\\liballoc.natvis" 
"/NATVIS:<sysroot>\\lib\\rustlib\\etc\\libcore.natvis" 
"/NATVIS:<sysroot>\\lib\\rustlib\\etc\\libstd.natvis" 
"/stack:8388608"
  = note: some arguments are omitted. use `--verbose` to show all linker arguments
  = note: rust-lld: error: /failifmismatch: mismatch detected for 'RuntimeLibrary':␍
          >>> libwebrtc_sys-6386e47d54040949.rlib(0602fb52cb66f316-media_stream_track.o) has value MD_DynamicRelease␍
          >>> libwebrtc_sys-6386e47d54040949.rlib(video_frame.obj) has value MT_StaticRelease␍

[xulai1001]

Is there any way to remove livekit components entirely from the local build? I'm just testing the basic builds where livekit is irrevelant.

[JunkuiZhang]

Did you make any changes to the .cargo/config.toml file? It should include target-feature = "+crt-static" or else webrtc-sys won’t build properly.

[xulai1001]

Did you make any changes to the .cargo/config.toml file? It should include target-feature = "+crt-static" or else webrtc-sys won’t build properly.

Setting RUSTFLAGS to -C target-feature = "+crt-static" actually solved this problem. Many thanks!

p.s. I have set this flag before, but I've set it to "target-feature='-crt-static'" by mistake ......