[Suggestion] Exclude .emotes from being impacted by .effects

[seth-rah]

Summary

So right now with the different "effects" available, they seem to impact the entire message posted.

this can lead to some conflicts with emotes that might have been configured

If you put some channel emotes into the emote list. Robot will use them, but when an effect is applied to a message, it will try to adapt the emote to fit the effects style, effectively break the emote if it's something available on Twitch.

One potential issue I foresee with adding this capability is that it might be that you'd want the emotes to also be impacted by some effects. Like maybe AAAAA as an example, although different owners could have different requirements.

To avoid over complicating, maybe each effect could have a hard-coded value on whether it can impact emotes configured or not.

[zephyrtronium]

Effects applying to emotes ties into Robot's theme of discovering new semantic ideas from surprising syntax. E.g., AAAAA applied to ( ͡° ͜ʖ ͡°) becomes ( ͡° ͜A ͡°) which is kinda silly; and o applied to cirBark inspired corBork and a series of related emotes that the respective chats enjoy independently, and similar for DIESOFCRINGE -> DOOSOFCRONGO, IAMTHESTORMTHATISAPPROACHING -> OOMTHOSTORMTHOTOSOPPROOCHONG, and I think a couple more.

I would say this needs to be configurable per effect × channel. Instead of

[global.effects]
'o' = 1
[twitch.bocchi.effects]
'OwO' = 2

we would want something like

[global]
effects = [
    { effect = 'o', weight = 1, also_apply_to_the_randomly_selected_emote = true },
]
[twitch.bocchi]
effects = [
    { effect = 'OwO', weight = 1, also_apply_to_the_randomly_selected_emote = false },
    { effect = 'OwO', weight = 1, also_apply_to_the_randomly_selected_emote = true },
]

This plays somewhat poorly with how effects are implemented currently, though, so it will be a non-trivial change. And although it is a good idea, I don't think I would use this feature, so it's low priority for me to do the work. And since it involves a change to config, it will conflict with work I have in progress for #58, so even accepting a PR would be difficult. In other words, backlog for now.

[seth-rah]

TIL: The origin of cirBork

Actually makes a lot of sense, didn't think of that. Thanks for the knowledge.

I'll keep my eye on the topic, but no rush at all. Thanks for sticking it in the backlog :)

[seth-rah]

A thought has occurred.

Something else that might be worth considering is to use a regular expression for terms that shouldn't have the effect applied rather than tying it to emotes specifically.

This way you can try to whitelist words starting with a certain prefix potentially instead of only targeting emotes you had configured in the emote list.

[zephyrtronium]

Currently, effects are just functions that take a string in and give a string back. It would be difficult to plumb that kind of configuration into the places it would need to go, especially since between random messages and explicit commands there are multiple paths that invoke effects.