Add plonky3 backend #461
Add plonky3 backend #461
Conversation
adr1anh
left a comment
adr1anh
left a comment
There was a problem hiding this comment.
Had a quick sneak peek, but this is great already! Left two small comments about the codegen.
adr1anh
left a comment
adr1anh
left a comment
There was a problem hiding this comment.
Looks really good! Just left some minor comments which can be addressed in a follow-up PR.
| pub trait AirBuilderWithPeriodicColumns: AirBuilder { | ||
| type PeriodicColumnsVar: Field + Into<Self::Expr>; | ||
|
|
||
| fn periodic_columns(&self) -> Vec<Self::PeriodicColumnsVar> { |
There was a problem hiding this comment.
We should also return a slice here which we can cast to an array.
There was a problem hiding this comment.
I think this is more complicated issue though, since I see below that we're using this to make testing easier.
| { | ||
| type PeriodicColumnsVar = F; | ||
|
|
||
| fn periodic_columns(&self) -> Vec<Self::PeriodicColumnsVar> { |
There was a problem hiding this comment.
While maybe not for this PR, I think we can represent periodic_columns in the DebugConstraintBuilderWithPeriodicColumns struct a bit differently
- Pad all periodic columns to the maximum length by periodic repetition
- Transpose the columns so that we have a vector of rows.
- We just return
&self.periodic_columns[self.row_index % col.len()]
There was a problem hiding this comment.
Hi! I've created an issue to do this in a followup: #492
| main.row_slice(0).unwrap(), | ||
| main.row_slice(1).unwrap(), | ||
| ); | ||
| builder.when_first_row().assert_zero::<_>(main_current[0] - AB::Expr::from(AB::F::from_u64(1))); |
There was a problem hiding this comment.
We should be able to call AB::Expr::from_u64().
There was a problem hiding this comment.
And as a followup, we should be able to replace this with AB::Expr::ONE
There was a problem hiding this comment.
Done in the latest commit with AB::Expr::ZERO, AB::Expr::ONE and AB::Expr::from_u64()
| ); | ||
| builder.when_first_row().assert_zero::<_>(main_current[3]); | ||
| builder.when_transition().assert_zero::<_>(main_next[16] - main_current[16] * ((main_current[3] * main_current[3] * main_current[3] * main_current[3] * main_current[3] * main_current[3] * main_current[3] * main_current[1] * main_current[2] + main_current[3] * main_current[3] * (AB::Expr::from(AB::F::from_u64(1)) - main_current[1]) * main_current[2] + main_current[3] * main_current[1] * (AB::Expr::from(AB::F::from_u64(1)) - main_current[2]) + (AB::Expr::from(AB::F::from_u64(1)) - main_current[1]) * (AB::Expr::from(AB::F::from_u64(1)) - main_current[2])) * main_current[0] - main_current[0] + AB::Expr::from(AB::F::from_u64(1)))); | ||
| builder.when_transition().assert_zero::<_>(main_next[3] - (main_current[4] + main_current[5] + main_current[6] + main_current[7] + main_current[8] + main_current[9] + main_current[10] + main_current[11] + main_current[12] + main_current[13] + main_current[14] + main_current[15] + AB::Expr::from(AB::F::from_u64(1))) * AB::Expr::from(AB::F::from_u64(2))); |
There was a problem hiding this comment.
Eventually we'd want to replace * AB::Expr::from(AB::F::from_u64(2))) with .double()
There was a problem hiding this comment.
Done in the latest commit, the only change I needed to introduce was to convert e.g. main_next[16] (an AB::Var) to an AB::Expr with .into() to have the double method available, which seems ok to me.
Al-Kindi-0
left a comment
Al-Kindi-0
left a comment
There was a problem hiding this comment.
Looks great!
Support and testing for periodic columns and buses will come in a follow up PR once we agree on how our version of P3 backend will look like.
| use p3_fri::create_benchmark_fri_params; | ||
| use p3_matrix::dense::RowMajorMatrix; | ||
| use p3_merkle_tree::MerkleTreeMmcs; | ||
| use p3_mersenne_31::Mersenne31; |
There was a problem hiding this comment.
nit (feel free to ignore): we can probably use just Goldilocks to stay consistent throughout
There was a problem hiding this comment.
Done in the latest commit!
Describe your changes
This PR aims to close #450.
Tasklist:
AirBuilderWithPeriodicColumnsandBaseAirWithPeriodicColumnsDebugConstraintBuilderWithPeriodicColumnscheck_constraints_with_periodic_columnsto check the constraints are valid for a given traceimplement the traits for upstream structs needed formoved to a followupproveandverifyNote that this PR will not include handling of: