Kernel ROM constraints #484
Open
+90
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adr1anh
reviewed
Sep 30, 2025
Al-Kindi-0
force-pushed
the
al-ace-constraints
branch
from
5b48e24 to
29c64e8
Compare
Al-Kindi-0
force-pushed
the
al-kerrom-constraints
branch
from
5082cbf to
6008145
Compare
Al-Kindi-0
added
the
no changelog
plafer
reviewed
Oct 30, 2025
constraints/kernel_rom.air
Outdated
| # Note: This constraint is disabled when the current row is the last row of the kernel ROM chiplet | ||
| # which is indicated by s4' being set to 1 | ||
| # | ||
| # TODO: Check if the following inlines to what is expected |
There was a problem hiding this comment.
Is this still relevant? It's unlikely to be done if left as a TODO in the code - should we instead create an issue?
Collaborator
Author
There was a problem hiding this comment.
Agreed, checking in-lining should be part of the sanity-checking work we will do to ensure the "soundness" of the passes
Removed now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist before requesting a review
nextaccording to naming convention.CHANGELOG.md