feat: expose rocksdb feature as opt-in #1326
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drahnr
changed the title
sergerad
reviewed
Nov 3, 2025
| termtree = { version = "0.5" } | ||
|
|
||
| [features] | ||
| default = [] # rocksdb has just too many requirements on CI for now |
Collaborator
There was a problem hiding this comment.
nit: comment formatting all good? might be formatter
sergerad
approved these changes
Nov 3, 2025
Contributor
Author
|
Requires 0xMiden/crypto#613 to be merged, otherwise we might get a panic. |
Base automatically changed from
bernhard-1227-account-tree-with-history
to
next
November 4, 2025 09:44
drahnr
force-pushed
the
bernhard-1227-add-optin-rocksdb-support
branch
from
a06e53f to
397aaa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only use
LargeSmt<Memory>with theMemorybackend. This is not very useful in practice, the entire purpose ofLargeSmtis having a disk backedSmtimplementation.This PR will ensure we have the
rocksdbfeature enabled inmiden-cryptountil it's extracted per #1218 .How it's done
We use the dependency feature unification of cargo to ensure we depend on
miden-cryptowith therocksdbfeature enabled. However, this incurs both a hefty penalty on compile times by default, compilingrocksdb-sysand additional CI dependencies, which leads to disabling it by default.Extras
Some additional type aliases are used to avoid lengthy types.