Make CompletionResponse's status optional #1177
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-mo-143
requested changes
Dec 19, 2025
Collaborator
joshua-mo-143
left a comment
joshua-mo-143
left a comment
There was a problem hiding this comment.
simple change then lgtm
Comment on lines
711
to
712
| /// The status of the response. | ||
| pub status: ResponseStatus, | ||
| pub status: Option<ResponseStatus>, |
Collaborator
There was a problem hiding this comment.
Please append a message onto the docstring to state that the reason for this being Option is for OpenRouter compatibility. Theoretically this should always be Some when using OpenAI's Responses API
Contributor
|
This is not a good idea IMO, status is NOT optional for openai. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1176.