Fix: Create search template for all sites. #4258
Open
+160
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeelia
reviewed
Jan 19, 2026
Member
felipeelia
left a comment
felipeelia
left a comment
There was a problem hiding this comment.
Few questions for you on this one @burhandodhy
Comment on lines
+1542
to
+1546
| * ## OPTIONS | ||
| * | ||
| * [--network-wide] | ||
| * : Delete the template for all sites in the network if plugin is network activated. Otherwise, delete the template for the current site only. | ||
| * |
Member
There was a problem hiding this comment.
Shouldn't this also affect the method code?
Contributor
Author
There was a problem hiding this comment.
It was my mistake; I have added the code.
| $sites = Utils\get_sites( 0, true ); | ||
| foreach ( $sites as $site ) { | ||
| switch_to_blog( $site['blog_id'] ); | ||
| $this->index = Indexables::factory()->get( 'post' )->get_index_name(); |
Member
There was a problem hiding this comment.
Any reason why we need this?
Contributor
Author
There was a problem hiding this comment.
It shouldn’t be there. I added that before making this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR ensures that the sync creates the search template across the network when the plugin is network-wide. It also adds support for the
network-wideflag forput-search-templatecommand.Additionally, we don’t need to set the
indexproperty during the constructor because if we runepio_save_site_search_template, the index property still holds the old value, which can cause incorrect endpoints.Closes #4227
How to test the Change
Changelog Entry
Credits
Props @burhandodhy @anjulahettige
Checklist: