Skip to content

Update accessible-emoji with enhancements from WebC bed #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update accessible-emoji with enhancements from WebC bed #9

wants to merge 4 commits into from

Conversation

@rdela
Copy link

@rdela rdela commented Aug 5, 2024 •
edited
Loading

https://github.com/rdela/webcbed/pulls?q=is%3Apr

Also introduces JSDoc-style comments, curious what we think about those.

@netlify
Copy link

netlify bot commented Aug 5, 2024 •
edited
Loading

✅ Deploy Preview for peppy-lokum-5edc39 ready!

Name Link
🔨 Latest commit a3e052b
🔍 Latest deploy log https://app.netlify.com/sites/peppy-lokum-5edc39/deploys/66b13c3cdd358b0008172ef5
😎 Deploy Preview https://deploy-preview-9--peppy-lokum-5edc39.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rdela
Copy link
Author

rdela commented Aug 5, 2024

Resolves recent symbol (⊛) issue in emoji-essential: WebReflection/emoji-essential#1

rdela added a commit to rdela/tugboat that referenced this pull request Aug 5, 2024
@rdela
Update visually-hidden with enhancements from WebC bed
756c61d 
https://github.com/rdela/webcbed/pulls?q=is%3Apr

Also, like 11ty#9, introduces
JSDoc-style comments, curious what we think about those.
@rdela rdela mentioned this pull request Aug 5, 2024
Open
@rdela
Copy link
Author

rdela commented Aug 5, 2024 •
edited
Loading

Hang on, I need to take care of when alt does not exist:

[11ty] Problem writing Eleventy templates:
[11ty] 1. Having trouble rendering webc template ./index.webc (via TemplateContentRenderError)
[11ty] 2. Check the webc:type="js" element in ./index.webc.
[11ty] Original error message: Cannot read properties of undefined (reading 'toString')
[11ty] 
[11ty] Original error stack trace: Error: Check the webc:type="js" element in ./index.webc.
[11ty] Original error message: Cannot read properties of undefined (reading 'toString')

UPDATE: emojiShortName(emoji) also undefined for newer emoji.

@rdela
Copy link
Author

rdela commented Aug 5, 2024

OK turns out 🖇️ is too new to be in emoji-essential/emoji-short-name’s latest updates.

rdela added a commit to rdela/tugboat that referenced this pull request Aug 5, 2024
@rdela
newer emoji may not be in emoji-essential, so we need to be extra def…
24a45a1 
…ensive

11ty#9 (comment)
rdela added a commit to rdela/webcbed that referenced this pull request Aug 5, 2024
@rdela
newer emoji may not be in emoji-essential, so we need to be extra def…
80203ef 
…ensive

11ty/tugboat#9 (comment)
@rdela rdela mentioned this pull request Aug 5, 2024
Merged
rdela added a commit to rdela/webcbed that referenced this pull request Aug 5, 2024
@rdela
newer emoji may not be in emoji-essential, so we need to be extra def…
2bf83a4 
…ensive (#6)

80203ef 11ty/tugboat#9 (comment)
@rdela
Copy link
Author

rdela commented Aug 5, 2024

Screenshot of ⊛ aka CIRCLED ASTERISK OPERATOR on https://tugboat.11ty.dev

Screenshot 2024-08-05 at 133726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rdela