SYCL optimization for cache friendly data structure #1259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…barrier instruction
Merge mdlReal and mdlImag to a single array with doubled size for cache efficient access Make required change and some cleanups for this mdlReal/mdlImag to mdlComplex in the required files in src/acc/ directory Change no_tex2D and no_tex3D to this mdlReal and mdlImag merging optimization (src/acc/sycl/sycl_kernels/sycl_utils.h) Remove unused complex2D and complex3D
do-jason
requested review from
CharlesCongdon,
biochem-fan,
dkimanius and
scheres
Member
|
Thank you very much for your continued contribution. The change looks OK to me but I do not have time to test this on many datasets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling and running are checked for legacy, CPU, and CUDA acceleration code path.