-
Notifications
You must be signed in to change notification settings - Fork 4
feat(terraform): Add grafana server #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💰 Infracost reportMonthly estimate increased by $9 📈
*Usage costs were estimated using Infracost Cloud settings, see docs for other options. Estimate details✅ Policies passed This comment will be updated when code changes. |
Terraform Format and Style success ✅Terraform Validation success ✅TFLint success ✅ |
terraform apply -chdir='terraform/development' -lock=true tf.planApply complete! Resources: 0 added, 0 changed, 0 destroyed.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Re-approving to read the grafana check data source. |
We only need the status code to pass. Previous workflow failed due to size of the body returned by the data source.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This breaks the workflow because running a plan always generates a diff as the data source is read so the idempotency check fails.
This comment has been minimized.
This comment has been minimized.
Terraform apply successful 🚀Summary of changes. |
3ware-release bot
pushed a commit
that referenced
this pull request
Oct 23, 2024
## [1.3.0](v1.2.0...v1.3.0) (2024-10-23) ### Features * **terraform:** Add grafana server ([#33](#33)) ([2ef4c64](2ef4c64))
Contributor
|
This PR is included in version 1.3.0 |
chris3ware
pushed a commit
that referenced
this pull request
Oct 23, 2024
## [1.3.0](v1.2.0...v1.3.0) (2024-10-23) ### Features * **terraform:** Add grafana server ([#33](#33)) ([2ef4c64](2ef4c64))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add grafana server to gitops AWS account.
I've disabled the
checkblock because it breaks the idempotency check as the data source is always read - generating a diff. I need to investigate how best to proceed with this.