Skip to content

Conversation

@chris3ware
Copy link
Member

@chris3ware chris3ware commented Oct 23, 2024

PR to add grafana server to gitops AWS account.

I've disabled the check block because it breaks the idempotency check as the data source is always read - generating a diff. I need to investigate how best to proceed with this.

@chris3ware chris3ware requested a review from a team as a code owner October 23, 2024 09:59
@github-actions
Copy link

github-actions bot commented Oct 23, 2024

💰 Infracost report

Monthly estimate increased by $9 📈

Changed project Baseline cost Usage cost* Total change New monthly cost
3ware/gitops-2024/terraform/development +$9 +$0 +$9 $9

*Usage costs were estimated using Infracost Cloud settings, see docs for other options.

Estimate details
Key: * usage cost, ~ changed, + added, - removed

──────────────────────────────────
Project: development
Module path: development

+ aws_instance.grafana_server
  +$9

    + Instance usage (Linux/UNIX, on-demand, t2.micro)
      +$8

    + root_block_device
    
        + Storage (general purpose SSD, gp2)
          +$0.80

Monthly cost change for 3ware/gitops-2024/terraform/development (Module path: development)
Amount:  +$9 ($0.00 → $9)

──────────────────────────────────
Key: * usage cost, ~ changed, + added, - removed

*Usage costs were estimated using Infracost Cloud settings, see docs for other options.

10 cloud resources were detected:
∙ 1 was estimated
∙ 9 were free

Infracost estimate: Monthly estimate increased by $9 ↑
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Changed project                                    ┃ Baseline cost ┃ Usage cost* ┃ Total change ┃
┣━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━━━╋━━━━━━━━━━━━━╋━━━━━━━━━━━━━━┫
┃ 3ware/gitops-2024/terraform/development            ┃           +$9 ┃         +$0 ┃          +$9 ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┻━━━━━━━━━━━━━━━┻━━━━━━━━━━━━━┻━━━━━━━━━━━━━━┛

✅ Policies passed

This comment will be updated when code changes.

@github-actions
Copy link

Terraform Format and Style success ✅

Terraform Validation success ✅

TFLint success ✅

@github-actions
Copy link

github-actions bot commented Oct 23, 2024

terraform apply -chdir='terraform/development' -lock=true tf.plan
Apply complete! Resources: 0 added, 0 changed, 0 destroyed.
By @chris3ware at 2024-10-23T11:11:50Z (view log).
Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

Outputs:

aws_account_id = <sensitive>
default_tags = tomap({
  "3ware:environment" = "development"
  "3ware:managed-by-terraform" = "true"
  "3ware:project-id" = "gitops-2024"
  "3ware:workspace" = "app-us-east-1-development"
})
grafana_ip = "http://44.200.218.125:3000"

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@chris3ware
Copy link
Member Author

Re-approving to read the grafana check data source.

We only need the status code to pass. Previous workflow failed due to
size of the body returned by the data source.
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the approved label Oct 23, 2024
This breaks the workflow because running a plan always generates a diff
as the data source is read so the idempotency check fails.
@github-actions

This comment has been minimized.

@github-actions
Copy link

Terraform apply successful 🚀

Summary of changes.

View run log.

@chris3ware chris3ware merged commit 2ef4c64 into main Oct 23, 2024
@chris3ware chris3ware deleted the feat-server-with-check branch October 23, 2024 11:20
3ware-release bot pushed a commit that referenced this pull request Oct 23, 2024
## [1.3.0](v1.2.0...v1.3.0) (2024-10-23)

### Features

* **terraform:** Add grafana server ([#33](#33)) ([2ef4c64](2ef4c64))
@3ware-release
Copy link
Contributor

3ware-release bot commented Oct 23, 2024

This PR is included in version 1.3.0

chris3ware pushed a commit that referenced this pull request Oct 23, 2024
## [1.3.0](v1.2.0...v1.3.0) (2024-10-23)

### Features

* **terraform:** Add grafana server ([#33](#33)) ([2ef4c64](2ef4c64))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants