TransferUtils #288
Open
TransferUtils #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
willronchetti
commented
Sep 29, 2023
willronchetti
commented
- A small addition to provision some baseline utilities for downloading files in parallel from the portal and from searches
- TODO: update with patching functionality once data model is in place
Pull Request Test Coverage Report for Build 6355336442
💛 - Coveralls |
| auth = get_authentication_with_server(key, ff_env) | ||
| get_url = '/'.join([auth['server'], _sls(obj_id)]).rstrip('/') + '/@@download' | ||
| response = authorized_request(get_url, auth=auth, verb='GET', allow_redirects=False) | ||
| return response.headers['Location'] |
Contributor
There was a problem hiding this comment.
Should this check for a 301?
Member
Author
There was a problem hiding this comment.
Given the @@download at the end it will throw exception prior either way if it doesn't find it, so not sure there is a huge point (there is no scenario where 301 isn't returned and this code is reached, it would have thrown exception prior to this point)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.