Skip to content

Conversation

@trivedikavya
Copy link

Description
Replaced manual debug = False flags and print statements with standard logger.debug() calls in WeatherRoutingTool/algorithms/isobased.py.

Related Issue
Closes #101

Verification

  • Ran pytest tests/test_isobased.py and all tests passed.

@trivedikavya
Copy link
Author

trivedikavya commented Dec 22, 2025

Hi @MartinPontius Sir,
Hope you’re doing well.
Could you please review this when you get a chance and share your feedback?

@kdemmich
Copy link
Collaborator

kdemmich commented Jan 5, 2026

Thank you for your PR. We appreciate the time and effort that was put into it but, unfortunately, we have to decline the PR as the added value to the tool is limited and does not justify a PR.

I would also like to take the chance to point you to our guidelines for software contributions which require to follow 52 North's CLA guidelines for all PRs and, in particular, fill the 52°North Contributor License Agreement. As long as this has not been filled, I can not assign you to any issues or merge any PRs. Please don't hesitate to contact me in case of related questions.

@kdemmich kdemmich closed this Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor: Replace manual debug flags with logger.debug in isobased.py

2 participants