Massive refactor #130
Open
Massive refactor #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow us to generate a documentation with an npm script. Prevent the generated documentation to be commited.
Make the TypeScript transpiler to warn us for every implicite "any" types to enforce types declaration in code.
Some npm's scripts run the "tsc" command in a way that generate .js and .js.map files. This commit allow us to clear the project from these files, without removing potentials stand-alone .js files.
The "clean" script use "rm" command which is not available on windows for example. A "rimraf" node module exists to solve this compatibility issue, but in this use case where the command was used to remove the node_modules folder it fails because the rimraf module has to delete itself.
Good practice: In prevision of more elaborate or alternative configurations. Allow us also to divide configuration in smaller files.
The @types/geojson module is a trap: It doesn't document the geojson module but the specification (RFC 7946). This commit add a proper .d.ts file to solve this issue.
In class definition, private member should be prefixed by an underscore and be accessed by the outside through getters and setters.
Contributor
Author
|
It looks like the CI job encounter networks issues |
Contributor
|
Can you run the tests on Travis again ? |
Contributor
Author
|
Travis passed build ;-) |
Contributor
Author
|
Solve #131 |
Contributor
Author
|
Solve #113 |
This was referenced Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #129