Remove non-working RSS <link> tag #87
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{{rsslink}} has been undefined since commit 63d1d95 (Fix RSS link).
I originally tried this change:
The substitution looked fine in the Firefox Inspector, but Firefox apparently parses the RSS URL too early during the page load process; clicking "Subscribe to this page" did nothing, and Tamper Data showed a GET request to
/acra-%7B%7Bacralyzer.app%7D%7D...Manually replacing {{acralyzer.app}} with my app's literal name made "Subscribe to this page" work again.
This page corroborates my claim that Firefox is picky about editing the
<link>href from Javascript, and suggests a few other alternatives:http://ask.metafilter.com/54377/Firefox-and-Javascript-issue