Skip to content

Conversation

@ahobbs7
Copy link
Collaborator

@ahobbs7 ahobbs7 commented Nov 13, 2025

Fixes tests to work with new dropdown menu. Includes changes made in adding dropdown and design fixes branch #22 which do not pass the tests.

@ahobbs7 ahobbs7 requested a review from llwiggins November 13, 2025 14:45
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.93%. Comparing base (52e57aa) to head (815cc64).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   98.68%   98.93%   +0.25%     
==========================================
  Files           3        3              
  Lines          76       94      +18     
==========================================
+ Hits           75       93      +18     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ahobbs7 ahobbs7 requested a review from ns-rse November 21, 2025 10:20
- Adds various files and directories to be ignored to `.gitignore` to avoid them creeping back in
- Disable pylint warning on specific line rather than globally
Copy link
Collaborator

@ns-rse ns-rse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed unnecessary files via #26

Tests fail locally for me with...

=================================================================== short test summary info ===================================================================
ERROR napari-afmreader/src/napari_afmreader_tests/_tests/test_reader.py::test_get_reader_returns_callable[load asd valid pass.] - ValueError: There is no existing handler with id 2
ERROR napari-afmreader/src/napari_afmreader_tests/_tests/test_reader.py::test_get_reader_returns_callable[load gwy valid pass.] - ValueError: There is no existing handler with id 5
ERROR napari-afmreader/src/napari_afmreader_tests/_tests/test_reader.py::test_get_reader_returns_callable[load ibw valid pass.] - ValueError: There is no existing handler with id 8
ERROR napari-afmreader/src/napari_afmreader_tests/_tests/test_reader.py::test_get_reader_returns_callable[load jpk valid pass.] - ValueError: There is no existing handler with id 11
ERROR napari-afmreader/src/napari_afmreader_tests/_tests/test_reader.py::test_get_reader_returns_callable[load spm valid pass.] - ValueError: There is no existing handler with id 14
ERROR napari-afmreader/src/napari_afmreader_tests/_tests/test_reader.py::test_get_reader_returns_callable[load stp single-pass.] - ValueError: There is no existing handler with id 17
ERROR napari-afmreader/src/napari_afmreader_tests/_tests/test_reader.py::test_get_reader_returns_callable[load top single-pass.] - ValueError: There is no existing handler with id 20
ERROR napari-afmreader/src/napari_afmreader_tests/_tests/test_reader.py::test_get_reader_returns_callable[load topostats image_original valid pass.] - ValueError: There is no existing handler with id 23
ERROR napari-afmreader/src/napari_afmreader_tests/_tests/test_reader.py::test_get_reader_returns_callable[load topostats image valid pass.] - ValueError: There is no existing handler with id 26
ERROR napari-afmreader/src/napari_afmreader_tests/_tests/test_reader.py::test_get_reader_returns_callable[load spm valid pass with channel kwarg.] - ValueError: There is no existing handler with id 29
================================================================ 12 passed, 10 errors in 3.43s ================================================================

Afraid I'm not familiar enough with GUI testing or what is going on here to be able to fix it given the need to sort out napari-TopoStats CI and continue with my refactoring.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR removes all of the parameters to the test_get_reader_returns_callable() test that check that when the wrong channel is specified specific to the file type the correct error message is returned which should include a list of available channels.

This may be intentional but I don't think we should be removing these as it is useful that we report the available channels when these errors occur. What is the reason for their removal?

Copy link
Collaborator

@ns-rse ns-rse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite tests failing locally for me they pass in CI.

I've noted my concern about removing checks that the available channels are reported when mis-specified in #27 so it can be discussed/addressed at a future point.

@ns-rse ns-rse merged commit dc2c0a4 into main Nov 26, 2025
12 checks passed
@ns-rse ns-rse deleted the ahobbs7/fixing_tests branch November 26, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants