-
Notifications
You must be signed in to change notification settings - Fork 1
Fixing tests (incorporates changes from design fixes and adding dropdown) #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to ahobbs7/adding_dropdown
…napari-AFMReader into ahobbs7/adding_dropdown
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 98.68% 98.93% +0.25%
==========================================
Files 3 3
Lines 76 94 +18
==========================================
+ Hits 75 93 +18
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…lt of the dropdown
…ari-AFMReader into ahobbs7/fixing_tests Merging due to pre-commit changes
- Adds various files and directories to be ignored to `.gitignore` to avoid them creeping back in - Disable pylint warning on specific line rather than globally
ns-rse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed unnecessary files via #26
Tests fail locally for me with...
=================================================================== short test summary info ===================================================================
ERROR napari-afmreader/src/napari_afmreader_tests/_tests/test_reader.py::test_get_reader_returns_callable[load asd valid pass.] - ValueError: There is no existing handler with id 2
ERROR napari-afmreader/src/napari_afmreader_tests/_tests/test_reader.py::test_get_reader_returns_callable[load gwy valid pass.] - ValueError: There is no existing handler with id 5
ERROR napari-afmreader/src/napari_afmreader_tests/_tests/test_reader.py::test_get_reader_returns_callable[load ibw valid pass.] - ValueError: There is no existing handler with id 8
ERROR napari-afmreader/src/napari_afmreader_tests/_tests/test_reader.py::test_get_reader_returns_callable[load jpk valid pass.] - ValueError: There is no existing handler with id 11
ERROR napari-afmreader/src/napari_afmreader_tests/_tests/test_reader.py::test_get_reader_returns_callable[load spm valid pass.] - ValueError: There is no existing handler with id 14
ERROR napari-afmreader/src/napari_afmreader_tests/_tests/test_reader.py::test_get_reader_returns_callable[load stp single-pass.] - ValueError: There is no existing handler with id 17
ERROR napari-afmreader/src/napari_afmreader_tests/_tests/test_reader.py::test_get_reader_returns_callable[load top single-pass.] - ValueError: There is no existing handler with id 20
ERROR napari-afmreader/src/napari_afmreader_tests/_tests/test_reader.py::test_get_reader_returns_callable[load topostats image_original valid pass.] - ValueError: There is no existing handler with id 23
ERROR napari-afmreader/src/napari_afmreader_tests/_tests/test_reader.py::test_get_reader_returns_callable[load topostats image valid pass.] - ValueError: There is no existing handler with id 26
ERROR napari-afmreader/src/napari_afmreader_tests/_tests/test_reader.py::test_get_reader_returns_callable[load spm valid pass with channel kwarg.] - ValueError: There is no existing handler with id 29
================================================================ 12 passed, 10 errors in 3.43s ================================================================
Afraid I'm not familiar enough with GUI testing or what is going on here to be able to fix it given the need to sort out napari-TopoStats CI and continue with my refactoring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR removes all of the parameters to the test_get_reader_returns_callable() test that check that when the wrong channel is specified specific to the file type the correct error message is returned which should include a list of available channels.
This may be intentional but I don't think we should be removing these as it is useful that we report the available channels when these errors occur. What is the reason for their removal?
chore: remove & ignore unnecessary files
ns-rse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despite tests failing locally for me they pass in CI.
I've noted my concern about removing checks that the available channels are reported when mis-specified in #27 so it can be discussed/addressed at a future point.
Fixes tests to work with new dropdown menu. Includes changes made in adding dropdown and design fixes branch #22 which do not pass the tests.