Add loongson generic 2k0300 device support #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AirFortressIlikara
force-pushed
the
LS2K0300
branch
from
5e637f4 to
3155a3f
Compare
Cyanoxygen
requested changes
Jul 7, 2025
Member
There was a problem hiding this comment.
- Please run
cargo fmtonce you finished your change. - Your image does not have a bootloader "installed" to it. You must supply at least a
boot.scrscript if it uses U-Boot (skip this if the U-Boot does automatically discover and boot the media.) - The above is to make sure your image will boot once the storage media is plugged in.
Please post a screenshot showing the device boots with your image written to an SD card, or a USB media.
AirFortressIlikara
force-pushed
the
LS2K0300
branch
from
3155a3f to
7d46e78
Compare
AirFortressIlikara
force-pushed
the
LS2K0300
branch
from
7d46e78 to
63b9e2f
Compare
AirFortressIlikara
force-pushed
the
LS2K0300
branch
2 times, most recently
from
7f4970a to
c081a36
Compare
Signed-off-by: Ilikara <[email protected]>
AirFortressIlikara
force-pushed
the
LS2K0300
branch
from
c081a36 to
e37c398
Compare
Cyanoxygen
reviewed
Nov 24, 2025
Member
Cyanoxygen
left a comment
Cyanoxygen
left a comment
There was a problem hiding this comment.
Rest of them LGTM. Thanks!
| name = "Generic LS2K0300 Board" | ||
|
|
||
| bsp_packages = [ | ||
| "linux-kernel-loongarch-2k0300-6.12.35" |
Member
There was a problem hiding this comment.
Remember to change this after you build the metapackage.
devices/loongson/2k0300/device.toml
Outdated
|
|
||
| vendor = "loongson" | ||
|
|
||
| arch = "loong_arch64" |
Member
There was a problem hiding this comment.
Why put an underscore? Shouldn't it be loongarch64?
AirFortressIlikara
force-pushed
the
LS2K0300
branch
from
e37c398 to
c0c3879
Compare
Signed-off-by: Ilikara <[email protected]>
warning: unnecessary parentheses around closure body
--> src/topics.rs:101:12
|
101 | .map(|x| (x + "\n"))
| ^ ^
|
= note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
help: remove these parentheses
|
101 - .map(|x| (x + "\n"))
101 + .map(|x| x + "\n")
|
Signed-off-by: Ilikara <[email protected]>
Signed-off-by: Ilikara <[email protected]>
AirFortressIlikara
force-pushed
the
LS2K0300
branch
from
c0c3879 to
245c5da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.