Skip to content

Fix: Connection leak in db_update_cluster() to prevent crashes in transactions #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yugalkaushik wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Connection leak in db_update_cluster() to prevent crashes in transactions #825

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb3037b
Fix connection leak in db_update_cluster() to prevent crashes in tran…
yugalkaushik Dec 23, 2025
3c79d2b
update fix
yugalkaushik Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions backend/app/database/face_clusters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,10 +226,12 @@ def db_update_cluster(
)

updated = cursor.rowcount > 0
conn.commit()
if own_connection:
conn.commit()
return updated
finally:
conn.close()
if own_connection:
conn.close()


def db_get_all_clusters_with_face_counts() -> (
Expand Down