Skip to content

Improve dev workflow by separating backend and Tauri frontend commands issue(fixes #837) #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
V4Vikaskumar wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Improve dev workflow by separating backend and Tauri frontend commands issue(fixes #837) #841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce69460
Fix missing useEffect dependencies in onboarding flow
V4Vikaskumar Dec 22, 2025
2d6756b
Update state management documentation
V4Vikaskumar Dec 22, 2025
6804000
Fix db_update_cluster connection handling
V4Vikaskumar Dec 24, 2025
b2d0c49
fix(dev): separate backend and tauri frontend run commands
V4Vikaskumar Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions backend/app/database/face_clusters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,10 +226,13 @@ def db_update_cluster(
)

updated = cursor.rowcount > 0
conn.commit()
if own_connection:
conn.commit()

return updated
finally:
conn.close()
if own_connection:
conn.close()


def db_get_all_clusters_with_face_counts() -> (
Expand Down
9 changes: 9 additions & 0 deletions docs/frontend/state-management.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,3 +235,12 @@ const folder = useSelector((state: RootState) =>
```

This Redux-based architecture provides a scalable and maintainable state management solution that grows with our application's complexity.

## React Hooks Guidelines

When working on frontend components, especially in onboarding flows:

- Always include all external variables, props, and functions used inside a `useEffect` hook in its dependency array.
- Avoid using empty dependency arrays (`[]`) when the effect relies on props, Redux dispatch, context values, or functions returned from custom hooks.
- This helps prevent stale closures, unexpected behavior, and navigation issues during multi-step flows.
- Follow the React Rules of Hooks and ensure ESLint hook rules pass before submitting a PR.
Loading