-
Notifications
You must be signed in to change notification settings - Fork 457
Home button in navbar does not scroll to top on landing page #856 #857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThree landing page components receive minor CSS padding adjustments. Added bottom padding (pb-2 or pb-3) to heading elements across FAQ, Home1, and pictopy-landing pages, tightening vertical spacing without altering functionality or rendering behavior. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
landing-page/src/Pages/Landing page/Home1.tsx (1)
1-66: Scroll-to-top fix not implemented in provided files.The PR description indicates a fix for Home button scroll-to-top behavior, but the reviewed file (Home1.tsx) contains only CSS padding adjustments. The landing-page Navbar component exists with a Home button that navigates to "/" without implementing scroll-to-top logic. Either the Navbar component needs to be updated with scroll-to-top functionality when clicking Home, or the PR description should be clarified.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
landing-page/src/Pages/FaqPage/FAQ.tsxlanding-page/src/Pages/Landing page/Home1.tsxlanding-page/src/Pages/pictopy-landing.tsx
🔇 Additional comments (3)
landing-page/src/Pages/FaqPage/FAQ.tsx (1)
58-60: Minor styling adjustment looks fine, but this doesn't address the PR objective.The
pb-3padding addition is a valid styling tweak. However, the PR claims to fix the Home button scroll-to-top behavior, yet this file only contains a CSS padding change with no navigation or scroll handling logic.Please verify that the actual Home button scroll fix is included in this PR (likely in a navbar component not shown here).
landing-page/src/Pages/pictopy-landing.tsx (1)
59-61: Padding adjustment is acceptable.The
pb-3class adds minor bottom spacing to the heading. This is a harmless UI tweak that aligns with the styling changes in the other files.However, like the other files in this PR, this doesn't contain the Home button scroll-to-top fix described in the PR objectives.
landing-page/src/Pages/Landing page/Home1.tsx (1)
21-24: Styling change is fine.The
pb-2padding addition provides consistent spacing below the heading, matching the styling pattern applied in the other files.
Fixing - #856
Description
The issue where the Home button in the navbar was not functioning on the landing page has been fixed.
Previously, clicking the Home button did not scroll or redirect the user to the top of the page, resulting in broken navigation behavior. The problem was caused by missing or incorrect scroll/navigation handling for the Home button.
Fix Implemented
Steps to Verify
✅ The page now correctly scrolls to the top.
Result
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.