Skip to content

Fix: Home button now scrolls to top smoothly on landing page (#856) #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
varsharaodevaraj wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Home button now scrolls to top smoothly on landing page (#856) #859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions landing-page/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { ScrollProgress } from "./components/ui/ScrollProgress";

function HomePage() {
return (
<>
<div id="home">
<Home /> {/* This will now render the Home component */}
<ScrollProgress></ScrollProgress>
<InteractiveDemo />
Expand All @@ -24,7 +24,7 @@ function HomePage() {
<PictopyLanding />
<FAQ />
<Footer />
</>
</div>
);
}

Expand Down
14 changes: 9 additions & 5 deletions landing-page/src/Pages/Landing page/Navbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,14 @@ const NavLink: React.FC<NavLinkProps> = ({
const element = document.getElementById(targetId);

if (element) {
// Scroll to the element with smooth behavior
element.scrollIntoView({
// Scroll with offset to account for sticky navbar
const offset = 90;
const elementTop = element.getBoundingClientRect().top + window.scrollY;
const targetScroll = elementTop - offset;

window.scrollTo({
top: targetScroll,
behavior: "smooth",
block: "start",
});
}

Expand Down Expand Up @@ -144,7 +148,7 @@ const Navbar: React.FC = () => {

{/* Desktop Navigation */}
<div className="hidden md:flex items-center space-x-8">
<NavLink to="/">Home</NavLink>
<NavLink to="#home" isScrollLink={true}>Home</NavLink>

{/* Dark Mode Toggle Button */}
<button
Expand Down Expand Up @@ -191,7 +195,7 @@ const Navbar: React.FC = () => {
>
<div className="pt-16 pb-6 px-4 space-y-6">
<div className="space-y-4 flex flex-col items-start">
<NavLink to="/" onClick={() => setIsOpen(false)}>
<NavLink to="#home" isScrollLink={true} onClick={() => setIsOpen(false)}>
Home
</NavLink>
<NavLink to="#features" isScrollLink={true} onClick={() => setIsOpen(false)}>
Expand Down