Mona #16
Open
Mona #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
May 6, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Mona, you hit the learning goals here. Well done. I had a few minor comments , but this is solid work!
Comment on lines
+4
to
+6
| # Time Complexity: O(n log n) | ||
| # Space Complexity: O(n) | ||
| def heapsort(list) |
Comment on lines
+17
to
19
| # Time Complexity: O(log n) | ||
| # Space Complexity: O(log n) - n is the number of elemnts in the heap | ||
| def add(key, value = key) |
Comment on lines
+28
to
30
| # Time Complexity: O(log n) | ||
| # Space Complexity: O(log n) | ||
| def remove() |
Comment on lines
+54
to
56
| # Time complexity: O(1) | ||
| # Space complexity: O(1) | ||
| def empty? |
Comment on lines
+65
to
67
| # Time complexity: O(log n) | ||
| # Space complexity: O(log n) | ||
| def heap_up(index) |
Comment on lines
+89
to
+95
| if left_child < @store.length && @store[left_child].key < @store[min_child].key | ||
| swap(min_child, left_child) | ||
| end | ||
|
|
||
| if right_child < @store.length && @store[right_child].key < @store[min_child].key | ||
| swap(min_child, right_child) | ||
| end |
There was a problem hiding this comment.
This works, but you could end up doing more swaps than needed.
Comment on lines
79
to
82
| # This helper method takes an index and | ||
| # moves it up the heap if it's smaller | ||
| # than it's parent node. | ||
| def heap_down(index) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?