-
Notifications
You must be signed in to change notification settings - Fork 37
Water & Earth - Iris & Kal #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
kaidamasaki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For TicTacToe we reviewed test results, the checkForWinner function, and onClickCallback function.
Good work implementing a React project using state and callback functions!
| for(let i in squares){ | ||
| if (squares[i][0].value === squares[i][1].value && squares[i][1].value === squares[i][2].value && squares[i][0].value !== ''){ | ||
| return `Winner is player ${squares[i][0].value}`; | ||
| } | ||
| else if(squares[0][i].value === squares[1][i].value && squares[1][i].value === squares[2][i].value && squares[0][i].value !== ''){ | ||
| return `Winner is player ${squares[0][i].value}`; | ||
| }; | ||
| } | ||
|
|
||
| if((squares[1][1].value !== '') && ((squares[1][1].value === squares[0][0].value && squares[2][2].value === squares[0][0].value) || (squares[1][1].value === squares[0][2].value && squares[1][1].value === squares[2][0].value))){ | ||
| return `Winner is player ${squares[1][1].value}`; | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You had test errors because you didn't match the expected format:
| for(let i in squares){ | |
| if (squares[i][0].value === squares[i][1].value && squares[i][1].value === squares[i][2].value && squares[i][0].value !== ''){ | |
| return `Winner is player ${squares[i][0].value}`; | |
| } | |
| else if(squares[0][i].value === squares[1][i].value && squares[1][i].value === squares[2][i].value && squares[0][i].value !== ''){ | |
| return `Winner is player ${squares[0][i].value}`; | |
| }; | |
| } | |
| if((squares[1][1].value !== '') && ((squares[1][1].value === squares[0][0].value && squares[2][2].value === squares[0][0].value) || (squares[1][1].value === squares[0][2].value && squares[1][1].value === squares[2][0].value))){ | |
| return `Winner is player ${squares[1][1].value}`; | |
| }; | |
| for(let i in squares){ | |
| if (squares[i][0].value === squares[i][1].value && squares[i][1].value === squares[i][2].value && squares[i][0].value !== ''){ | |
| return `Winner is ${squares[i][0].value}`; | |
| } | |
| else if(squares[0][i].value === squares[1][i].value && squares[1][i].value === squares[2][i].value && squares[0][i].value !== ''){ | |
| return `Winner is ${squares[0][i].value}`; | |
| }; | |
| } | |
| if((squares[1][1].value !== '') && ((squares[1][1].value === squares[0][0].value && squares[2][2].value === squares[0][0].value) || (squares[1][1].value === squares[0][2].value && squares[1][1].value === squares[2][0].value))){ | |
| return `Winner is ${squares[1][1].value}`; | |
| }; |
React Tic Tac Toe
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
useStateconnected?CS Fundamentals Questions
setState-- it must re-render all of the components that now have different content because of that change.What kind of data structure are the components in, and what sort of algorithms would be appropriate for React's code to "traverse" those components?
Speculate wildly about what the Big-O time complexity of that code might be.