Fire - Ayesha & Water - Sophia #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spitsfire
reviewed
Jan 6, 2021
There was a problem hiding this comment.
React Tic Tac Toe
Major Learning Goals/Code Review
| Criteria | yes/no, and optionally any details/lines of code to reference |
|---|---|
| Demonstrates proper JavaScript coding style. | ✔️ |
| Correctly passes props to child components. | ✔️ |
| Correctly passes callback functions to child components and calls them to respond to user events.) | ✔️ |
| Maintains the status of the game in state. | ✔️ |
| Practices git with at least 6 small commits and meaningful commit messages | ✔️ |
| Uses existing stylesheets to render components | ✔️ |
Functional Requirements
| Functional Requirement | yes/no |
|---|---|
The Square component renders properly and executes the callback on a click event. |
✔️ |
| The Board component renders a collection of squares | ✔️ |
The App component renders a board and uses state to maintain the status of the game. |
✔️ |
| Utilizes callbacks to UI events to update state | ✔️ |
Overall Feedback
| Overall Feedback | Criteria | yes/no |
|---|---|---|
| Green (Meets/Exceeds Standards) | 5+ in Code Review && 3+ in Functional Requirements | ✔️ |
| Yellow (Approaches Standards) | 4+ in Code Review && 2+ in Functional Requirements, or the instructor judges that this project needs special attention | |
| Red (Not at Standard) | 0-3 in Code Review or 0,1 in Functional Reqs, or assignment is breaking/doesn’t run with less than 5 minutes of debugging, or the instructor judges that this project needs special attention |
Additional Feedback
You have one test that is erroring out; however, that test is optional. If you wish, you can put it back as a skip should you so choose! So, don't worry that one of these tests is erroring out on Learn. I won't hold that against this assignment 👍
Code Style Bonus Awards
Was the code particularly impressive in code style for any of these reasons (or more...?)
| Quality | Yes? |
|---|---|
| Perfect Indentation | ✅ |
| Elegant/Clever | ✅ |
| Descriptive/Readable | ✅ |
| Concise | ✅ |
| Logical/Organized | ✅ |
| const Board = ({ squares, onClickCallback }) => { | ||
| const squareList = generateSquareComponents(squares, onClickCallback); | ||
| console.log(squareList); | ||
| // console.log(squareList); |
There was a problem hiding this comment.
make sure you get rid of any and all console.log statements before submitting, not just commenting them out
Comment on lines
+8
to
+16
| const onClickCallback = () => { | ||
| const updatedSquare = { | ||
| value: props.value, | ||
| id: props.id, | ||
| onClickCallback: props.onClickCallback | ||
| } | ||
|
|
||
| props.onUpdateSquare(updatedSquare); | ||
| } |
There was a problem hiding this comment.
looks like this was a function that was never used. it can be deleted.
kaidamasaki
reviewed
Jan 8, 2021
| for (let i = 0; i < squares.length; i += 1) { | ||
| for (let j = 0; j < squares.length; j += 1) { | ||
| if(event === squares[i][j].id){ | ||
| // need conditional to stop user from playing square if it is not an empty stringq |
There was a problem hiding this comment.
This missing conditional is why you have a failing test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Tic Tac Toe
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
useStateconnected?CS Fundamentals Questions
setState-- it must re-render all of the components that now have different content because of that change.What kind of data structure are the components in, and what sort of algorithms would be appropriate for React's code to "traverse" those components?
Speculate wildly about what the Big-O time complexity of that code might be.