Skip to content

Conversation

@GangGreenTemperTatum
Copy link
Contributor

@GangGreenTemperTatum GangGreenTemperTatum commented Oct 1, 2024

found a bug when running CI mode from multiple caller repos, example error indicates that the await keyword is being used outside of an async function:

│   187 │   │   │   "asyncio.run() cannot be called from a running event loop" │
│   188 │                                                                      │
│   189 │   with Runner(debug=debug) as runner:                                │
│ ❱ 190 │   │   return runner.run(main)     
  • run_evaluations and run_redflag are defined as async functions.
  • The cli function uses asyncio.run to run these async functions, ensuring that await is used correctly within an async context.
  • The eval command is properly handled by the evaluate_parser subparser.

note: slack=Slack, would need including on successful merge of #12

@GangGreenTemperTatum
Copy link
Contributor Author

hey @addepar-tg @henry-prince-addepar small suggestion to enable "always suggest updating pull request branches" :)

anyways, i pulled in the latest commits from main, ie #12 and pushed another commit chore: follow up async slack changes as per my comments, ie:

note: slack=Slack, would need including on successful merge of #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant