Skip to content

fix(ts): add options object with abort for onSelect #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukasnys wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(ts): add options object with abort for onSelect #1109

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdc6b6e
fix(ts): add options object with abort for onSelect
lukasnys Jul 10, 2024
75091b8
fix(ts): fix abort type to be a function
lukasnys Nov 20, 2024
de2bfd6
Merge remote-tracking branch 'origin/master' into fix-1064-abort-type
lukasnys Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/components/ember-tbody/component.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export interface EmberTbodyArgs<RowType extends EmberTableRow> {
* An action that is called when the row selection of the table changes.
* Will be called with either an array or individual row, depending on the checkboxSelectionMode.
*/
onSelect?: (rows: RowType[] | RowType) => void;
onSelect?: (rows: RowType[] | RowType, options: { abort: () => void }) => void;

/**
* A flag that tells the table to render all of its rows at once.
Expand Down