💎 Feature - Add display areas graphQl configuration

[dimitriBouteille]

Summary

This PR adds in the graphQl the following configurations :

• adyen_express_applepay_display_areas
• adyen_express_googlepay_display_areas
• adyen_express_paypal_express_display_areas

These configurations return an array of AdyenExpressDisplayArea.

{
    "data": {
        "storeConfig": {
            "adyen_express_applepay_display_areas": [
                "MINI_CART"
            ],
            "adyen_express_googlepay_display_areas": [
                "PRODUCT_PAGE",
                "CART_PAGE",
                "MINI_CART"
            ],
            "adyen_express_paypal_express_display_areas": [
                "CART_PAGE",
                "MINI_CART"
            ]
        }
    }
}

Tested scenarios

Execute this query and check if the returned configurations are correct.

query LoadAdyenExpressConfiguration {
    storeConfig {
        adyen_express_applepay_display_areas
        adyen_express_googlepay_display_areas
        adyen_express_paypal_express_display_areas
    }
}

[gemini-code-assist]

Summary of Changes

Hello @dimitriBouteille, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request extends the GraphQL API to provide frontend applications with access to the configured display areas for Adyen Express payment methods (Apple Pay, Google Pay, and PayPal Express). It achieves this by introducing new GraphQL fields and an associated resolver, allowing for dynamic rendering of payment method shortcuts based on backend settings.

Highlights

• New GraphQL Fields: This PR introduces three new fields to the StoreConfig GraphQL type: adyen_express_applepay_display_areas, adyen_express_googlepay_display_areas, and adyen_express_paypal_express_display_areas. These fields will expose the configured display locations for their respective Adyen Express payment methods.
• New GraphQL Enum Type: A new GraphQL enum type, AdyenExpressDisplayArea, has been added. This enum defines the possible display locations as CART_PAGE, MINI_CART, and PRODUCT_PAGE.
• GraphQL Resolver Implementation: A new PHP resolver, Model/Resolver/StoreConfig/DisplayAreas.php, has been implemented. This resolver is responsible for fetching the display area configurations from the backend and mapping them to the new AdyenExpressDisplayArea enum values for GraphQL consumption.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces GraphQL fields to expose display area configurations for Adyen express payment methods. There are a few critical issues that would lead to runtime failures: an incorrect resolver class path in the GraphQL schema and a faulty regular expression in the resolver logic. Additionally, there is a high-severity bug where the resolver could return data in a format that violates the GraphQL schema.

[candemiralp]

Hello @dimitriBouteille,

Thank you for creating this PR. We appreciate you commendable approach to extend the plugin configuration for GraphQL implementation.

We will review this PR and release it soon.

Best Regards,
Can

[dimitriBouteille]

@candemiralp Did you have time to look at this PR?

[candemiralp]

Hello @dimitriBouteille,

Thanks for the contribution once again and apologies for the delay.

The PR overall looks good and it's a really nice enhancement. I just added StoreManagerInterface to obtain the configuration values based on the configuration scope and rename the class for naming convention. Also, I added some unit tests.

Please let me know if these changes make sense for you! Then, we can proceed and merge this PR.

Best Regards,
Can

[dimitriBouteille]

Hi @candemiralp

Everything is good 🚀

Sorry, I don't take always the time to write tests :(

[candemiralp]

Thank you @dimitriBouteille!

This PR has now been merged. This will be released after the busiest times of the peak season as we have decided to release only fixes during this time.

Best Regards,
Can