Skip to content

Conversation

@gcatanese
Copy link
Contributor

Description

The OpenAPI specs deprecate endpoints and models, but the code generation of the NodeJS library doesn't deprecate the corresponding code.

Proposed improvement
Add the @deprecated tag to the corresponding code, include the extensions x-deprecatedInVersion and x-deprecatedMessage too.

@gcatanese gcatanese requested a review from a team October 2, 2024 14:56
jillingk
jillingk previously approved these changes Oct 3, 2024
@gcatanese
Copy link
Contributor Author

Thanks @jillingk. Please don't merge, I am pushing another change (deprecated operations)

@gcatanese gcatanese force-pushed the mark-deprecated-model-attributes branch from 4dc0724 to e0b0209 Compare October 11, 2024 13:24
@gcatanese gcatanese requested a review from a team as a code owner October 11, 2024 13:24
@Kwok-he-Chu Kwok-he-Chu self-requested a review October 15, 2024 12:08
@gcatanese gcatanese force-pushed the mark-deprecated-model-attributes branch from e0b0209 to 5d4afa0 Compare October 22, 2024 15:37
@gcatanese gcatanese force-pushed the mark-deprecated-model-attributes branch from 5d4afa0 to 317d064 Compare October 24, 2024 20:13
@sonarqubecloud
Copy link

@gcatanese gcatanese merged commit b9e0df2 into main Oct 24, 2024
8 checks passed
@gcatanese gcatanese deleted the mark-deprecated-model-attributes branch October 24, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants