Draft: Advanced filters with buttons for own deck page #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ajordat
reviewed
Jun 8, 2025
| for faction in Card.Faction.as_list(): | ||
| heroes = [ | ||
| card.name | ||
| for card in Card.objects.filter(type=Card.Type.HERO, faction=faction) |
Owner
There was a problem hiding this comment.
Here, heroes need to be filtered further. That's because each set reprints heroes but are still considered different cards. Furthermore, promos are also extracted with this query.
We should extract the cards that:
- type = hero
- set = CORE
- not promo
I can also see with DJDT (button on the right) that there are six queries that are very similar. That happens because this query is run one time per faction. I was wondering if we could reduce that to a single query and sorting heroes by faction and reference.
+ some setup modification
LavergneC
commented
Jun 12, 2025
| set=set, | ||
| main_effect=main_effect, | ||
| stats={"reserve_count": reserve_count, "permanent_count": permanent_count}, | ||
| **kwargs, |
Author
There was a problem hiding this comment.
I needed this in order to specify "is_promo" from generate_card
LavergneC
commented
Jun 12, 2025
| name=data["name"], | ||
| faction=faction, | ||
| card_set=data["card_set"] if card_set else None, | ||
| set=data["card_set"] if card_set else None, |
Author
There was a problem hiding this comment.
I've changed "card_set" to "set". I looked like an error and was preventing my set selection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.