Implemented "only-physical" parameter in the wireplumber module. #4714
+169
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes it find the first node that has adevice.id linked to the default output if the default output doesn't have it (i.e. it is a virtual output). Useful if you want to control (and see) the volume of the actual output and not the effect sink. May need some polishing and/or style fixing, but it works.
Author
|
I just realized that sometimes the processing nodes might actually have real outputs for processed audio (e.g. jack standalone effects). The current implementation works with the quirks of the filter-chain pipewire module, but disregards the more normal-looking jack standalone effects. I'll add it sometime tomorrow probably. Currently it breaks really ungracefully if used with a jack effect node. It kind of... crashes the whole bar. I'll also add some safe fallbacks and sanity checks while I'm at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes it find the first node that has adevice.id linked to the default output if the default output doesn't have it (i.e. it is a virtual output).
Useful if you want to control (and see) the volume of the actual output and not the effect sink.
May need some polishing and/or style fixing, but it works.
Somewhat related to #4678 , as it may cover some usecases of manual node selection.