Alien attempt #3

lursz · 2025-06-09T19:47:22Z

👽

* parallel v1 * thread count fix * parallel * small parallel fixes * working multithread solution * Multi-thread + vector plots * black, black used everywhere --------- Co-authored-by: Piotr Kubala <[email protected]>

* tests I guess * uv fix * planet impl * ground truth * gen plot function * unit tests, monoticity tests, sanity tests * tests are now in tests * added ground truth files * removed leftovers * npy files * tests tidyup * tests adapted for current structure but still useless * renamed test to comply with pytest convention * fix ground_truth generation script * refactor unittests * added accuracy tests * Added saturation test for cloud base in unit tests * Refactored imports and clean up unused code in simulation and parcel modules * Enhanced accuracy tests by adding assertions for output completeness and consistency in unit tests * Refactored calculation of simulated mass fraction evaporation point to initialize variable and improved error handling --------- Co-authored-by: Hevagog <[email protected]> Co-authored-by: Mateusz Mazur <[email protected]>

m8 u removed too much

Co-authored-by: Copilot <[email protected]>

mzsuetam

Looks good to me, but we need to address some of the changes proposed by Copilot

…gen_figure.py Using dir shadowed the built-in dir() function. Renamed this variable (e.g., root_dir) to avoid confusion. Co-authored-by: Copilot <[email protected]>

…notation

Co-authored-by: Copilot <[email protected]>

…ted diffusion_coordinate assignment

mzsuetam

Nice work, lets ship it! 🚢

piotrkubala

some comments

PySDM/physics/particle_shape_and_density/oblate_spheroid.py

PySDM/physics/terminal_velocity/lofus_et_al_2021.py

PySDM/physics/ventilation/lofus_et_al_2021.py

tests/examples_tests/Loftus_and_Wordsworth_2021/accuracy_test.py

…and density, terminal velocity, and ventilation modules

Copilot

Pull Request Overview

This PR integrates the Loftus & Wordsworth (2021) planetary raindrop example into the PySDM codebase, adding example modules and a comprehensive test suite.

Add new example package Loftus_and_Wordsworth_2021 with settings, planet definitions, parcel environment, and simulation driver
Introduce unit, accuracy, and ground-truth generation tests under tests/examples_tests/Loftus_and_Wordsworth_2021
Update conftest.py to discover the new example tests

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/examples_tests/conftest.py	Include `Loftus_and_Wordsworth_2021` in test-discovery patterns
tests/examples_tests/Loftus_and_Wordsworth_2021/unit_test.py	Unit tests for planet classes, parcel init, and simulation API
tests/examples_tests/Loftus_and_Wordsworth_2021/accuracy_test.py	Accuracy tests comparing simulation outputs to `.npy` ground truth
tests/examples_tests/Loftus_and_Wordsworth_2021/ground_truth/gen_figure.py	Script to regenerate Figure 2 ground truth data
examples/PySDM_examples/Loftus_and_Wordsworth_2021/settings.py	New `Settings` class for example configuration
examples/PySDM_examples/Loftus_and_Wordsworth_2021/simulation.py	New `Simulation` wrapper around PySDM builder/dynamics pipeline
examples/PySDM_examples/Loftus_and_Wordsworth_2021/planet.py	Planet‐specific dataclasses (EarthLike, Jupiter, etc.)
examples/PySDM_examples/Loftus_and_Wordsworth_2021/parcel.py	Custom `AlienParcel` subclass for environment dynamics
examples/PySDM_examples/Loftus_and_Wordsworth_2021/init.py	Package initialization and docstring
PySDM/physics/terminal_velocity/init.py	Adjusted module docstring formatting

Comments suppressed due to low confidence (3)

tests/examples_tests/conftest.py:86

[nitpick] Directory and module names are uppercase and use underscores; consider renaming to a lowercase package path to follow PEP 8 package naming conventions.

"Loftus_and_Wordsworth_2021",

tests/examples_tests/Loftus_and_Wordsworth_2021/ground_truth/gen_figure.py:95

The variable dir is undefined here; it should use the previously defined root_dir to construct the path.

figs_path = os.path.join(dir, "figs")

examples/PySDM_examples/Loftus_and_Wordsworth_2021/settings.py:34

si.metres is not a valid attribute; the correct SI unit property is si.metre.

self.z_half = 150 * si.metres

tests/examples_tests/Loftus_and_Wordsworth_2021/ground_truth/gen_figure.py

* simulation setup * uv lock * introduced all equations * oblate spheroid impl * AlienParcel class extending Parcel * PySDM package internal imports fix * Formulae bug fixes * Planet is now dataclass instead of dict * drop falling without pancake shape * cloudbase fix * figure settings * multicore support for simulation (#2) * parallel v1 * thread count fix * parallel * small parallel fixes * working multithread solution * Multi-thread + vector plots * black, black used everywhere --------- Co-authored-by: Piotr Kubala <[email protected]> * pip install joblib * Tests (#1) * tests I guess * uv fix * planet impl * ground truth * gen plot function * unit tests, monoticity tests, sanity tests * tests are now in tests * added ground truth files * removed leftovers * npy files * tests tidyup * tests adapted for current structure but still useless * renamed test to comply with pytest convention * fix ground_truth generation script * refactor unittests * added accuracy tests * Added saturation test for cloud base in unit tests * Refactored imports and clean up unused code in simulation and parcel modules * Enhanced accuracy tests by adding assertions for output completeness and consistency in unit tests * Refactored calculation of simulated mass fraction evaporation point to initialize variable and improved error handling --------- Co-authored-by: Hevagog <[email protected]> Co-authored-by: Mateusz Mazur <[email protected]> * Notebook not running fix - added back necessary imports m8 u removed too much * black formatter * black for ipynb * Update PySDM/physics/particle_shape_and_density/oblate_spheroid.py Co-authored-by: Copilot <[email protected]> * Updated tests/examples_tests/Loftus_and_Wordsworth_2021/ground_truth/gen_figure.py Using dir shadowed the built-in dir() function. Renamed this variable (e.g., root_dir) to avoid confusion. Co-authored-by: Copilot <[email protected]> * Fixed pressure values in Planet subclasses to use correct scientific notation * Updated method signature for proper binding. Co-authored-by: Copilot <[email protected]> * Refactored Settings class to remove unused 'coord' parameter and updated diffusion_coordinate assignment * Removed unused Lofus et al. 2021 implementations from particle shape and density, terminal velocity, and ventilation modules * plots warnings fixes * removed files rogers and yau * notebook rerun * notebook fix * minor linter fixes --------- Co-authored-by: emmacware <[email protected]> Co-authored-by: Piotr Kubala <[email protected]> Co-authored-by: Hevagog <[email protected]> Co-authored-by: Mateusz Mazur <[email protected]>

emmacware and others added 18 commits May 26, 2025 22:58

simulation setup

58ba2aa

uv lock

cd6a231

introduced all equations

dcdee65

oblate spheroid impl

60188ce

AlienParcel class extending Parcel

9e8881d

PySDM package internal imports fix

363c0a8

Formulae bug fixes

d84133d

Planet is now dataclass instead of dict

fa1043b

drop falling without pancake shape

92af9d9

cloudbase fix

389eee1

Merge branch 'main' into alienattempt

9d0ec86

figure settings

df9287a

multicore support for simulation (#2)

ce24cb6

* parallel v1 * thread count fix * parallel * small parallel fixes * working multithread solution * Multi-thread + vector plots * black, black used everywhere --------- Co-authored-by: Piotr Kubala <[email protected]>

pip install joblib

083ecbd

Notebook not running fix - added back necessary imports

635dfd1

m8 u removed too much

black formatter

ff78f35

black for ipynb

9043d3c

lursz changed the base branch from develop to main June 9, 2025 21:46

lursz requested review from Hevagog, Copilot, emmacware, mzsuetam and piotrkubala June 9, 2025 21:48

This comment was marked as outdated.

Sign in to view

Hevagog approved these changes Jun 9, 2025

View reviewed changes

Update PySDM/physics/particle_shape_and_density/oblate_spheroid.py

147e3f7

Co-authored-by: Copilot <[email protected]>

mzsuetam requested changes Jun 10, 2025

View reviewed changes

mzsuetam and others added 2 commits June 10, 2025 13:18

Updated tests/examples_tests/Loftus_and_Wordsworth_2021/ground_truth/…

e060147

…gen_figure.py Using dir shadowed the built-in dir() function. Renamed this variable (e.g., root_dir) to avoid confusion. Co-authored-by: Copilot <[email protected]>

Fixed pressure values in Planet subclasses to use correct scientific …

6ea0e62

…notation

mzsuetam and others added 2 commits June 10, 2025 13:23

Updated method signature for proper binding.

51558ab

Co-authored-by: Copilot <[email protected]>

Refactored Settings class to remove unused 'coord' parameter and upda…

7b75eba

…ted diffusion_coordinate assignment

mzsuetam approved these changes Jun 10, 2025

View reviewed changes

piotrkubala reviewed Jun 10, 2025

View reviewed changes

emmacware approved these changes Jun 10, 2025

View reviewed changes

mzsuetam and others added 3 commits June 10, 2025 14:22

Removed unused Lofus et al. 2021 implementations from particle shape …

bf2988f

…and density, terminal velocity, and ventilation modules

plots warnings fixes

cb77758

removed files rogers and yau

85cbb2c

mzsuetam requested a review from Copilot June 10, 2025 12:59

Copilot AI reviewed Jun 10, 2025

View reviewed changes

tests/examples_tests/Loftus_and_Wordsworth_2021/ground_truth/gen_figure.py Show resolved Hide resolved

piotrkubala added 3 commits June 10, 2025 15:11

notebook rerun

62ab74e

notebook fix

e510e5f

minor linter fixes

e128d61

lursz changed the base branch from main to rain-on-me June 10, 2025 14:42

lursz merged commit 4e00199 into rain-on-me Jun 10, 2025
23 of 28 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alien attempt #3

Alien attempt #3

Uh oh!

lursz commented Jun 9, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

mzsuetam left a comment

Uh oh!

mzsuetam left a comment

Uh oh!

piotrkubala left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Alien attempt #3

Alien attempt #3

Uh oh!

Conversation

lursz commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

mzsuetam left a comment

Choose a reason for hiding this comment

Uh oh!

mzsuetam left a comment

Choose a reason for hiding this comment

Uh oh!

piotrkubala left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lursz commented Jun 9, 2025 •

edited

Loading