Fix incorrectly named npmSymbol #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure this is the right way to fix this. If you enable `plc_npm_npmSymbol` in the powerline config, then you get a crash because `npmSymbol` isn't actually defined anywhere. I think that was supposed to point to `plc_npm_npmSymbol` instead. Of course, the config and this file hasn't been changed in many months so either no one is using this, no one has bothered to submit a fix, or I'm doing this all wrong.
|
I see now that this was also fixed in the unrelated PR #53 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure this is the right way to fix this.
If you enable
plc_npm_npmSymbolin the powerline config, then you get a crash becausenpmSymbolisn't actually defined anywhere. I think that was supposed to point toplc_npm_npmSymbolinstead.Of course, the config and this file hasn't been changed in many months so either no one is using this, no one has bothered to submit a fix, or I'm doing this all wrong.