Added disable_when_fullscreen for hyprland #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasBackx
requested changes
Sep 10, 2025
Owner
AndreasBackx
left a comment
AndreasBackx
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Unfortunately, I'm not sure that calling hyprctl each time is a good idea. I feel like there should be a better way of doing this, via some Wayland API. If that exists, I might consider the implementation. I don't think doing this is a great solution.
If you want to unblock yourself, you could accomplish this by setting the command to something like hyprctl activewindow -j | SOME_JK_PIPING_MAGIC && $COMMAND.
Let me know if you know of such a Wayland API existing.
Author
|
Yeah I'm not aware of a universal API for Wayland that can check for fullscreen... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves #35
Added a config variable disable_when_fullscreen. When set to true (default), waycorner won't activate when a window is fully fullscreen (maybe default of false is better?). Only added for hyprland, but setup is there to extend to sway etc. Also if ran with --preview the corners will still be visible when fullscreen, should be a non-issue if --preview is only used for debugging.