-
-
Notifications
You must be signed in to change notification settings - Fork 7
Add comprehensive GitHub Copilot instructions for AngleSharp.Diffing development #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,196 @@ | ||||||
| # AngleSharp.Diffing - HTML Comparison Library | ||||||
|
|
||||||
| AngleSharp.Diffing is a .NET library for comparing AngleSharp control nodes and test nodes to identify differences between HTML DOM trees. This library targets .NET Standard 2.0 and provides a fluent API for HTML comparison and diffing. | ||||||
|
|
||||||
| **Always reference these instructions first and fallback to search or bash commands only when you encounter unexpected information that does not match the info here.** | ||||||
|
|
||||||
| ## Working Effectively | ||||||
|
|
||||||
| ### Prerequisites and Setup | ||||||
| - Install .NET 8.0+ SDK (already available in GitHub Actions environments) | ||||||
| - Mono is NOT required for standard development (only for legacy Cake build system) | ||||||
|
|
||||||
| ### Bootstrap, Build, and Test | ||||||
| Execute these commands in order from the repository root: | ||||||
|
|
||||||
| ```bash | ||||||
| cd src | ||||||
| dotnet restore # ~11 seconds - restores NuGet packages | ||||||
| dotnet build # ~15 seconds - compiles library and tests | ||||||
| dotnet test # ~5 seconds - runs 521 tests. NEVER CANCEL. | ||||||
| ``` | ||||||
|
|
||||||
| **CRITICAL TIMING EXPECTATIONS:** | ||||||
| - `dotnet restore`: 11 seconds - NEVER CANCEL. Set timeout to 60+ seconds minimum. | ||||||
| - `dotnet build`: 15 seconds - NEVER CANCEL. Set timeout to 60+ seconds minimum. | ||||||
| - `dotnet test`: 5 seconds - runs 521 tests. NEVER CANCEL. Set timeout to 30+ seconds minimum. | ||||||
| - Complete clean rebuild: ~20 seconds - NEVER CANCEL. Set timeout to 60+ seconds minimum. | ||||||
|
|
||||||
| ### Alternative Build Methods | ||||||
| **PRIMARY METHOD (Recommended):** Use dotnet CLI commands as shown above. | ||||||
|
|
||||||
| **LEGACY METHOD (Not Recommended):** The repository includes Cake build scripts (`build.sh`/`build.ps1`) but they require Mono and may fail. Only use if specifically needed: | ||||||
| ```bash | ||||||
| # Install Mono first (if needed) | ||||||
| sudo apt-get update && sudo apt-get install -y mono-complete | ||||||
| ./build.sh # May fail - use dotnet commands instead | ||||||
| ``` | ||||||
|
|
||||||
| ### Release Builds and Packaging | ||||||
| ```bash | ||||||
| cd src | ||||||
| dotnet build --configuration Release # ~15 seconds | ||||||
| dotnet pack --configuration Release # ~8 seconds - creates NuGet packages | ||||||
|
||||||
| dotnet pack --configuration Release # ~8 seconds - creates NuGet packages | |
| dotnet pack --configuration Release # 8 seconds - creates NuGet packages |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 27 shows ~20 seconds for complete clean rebuild, but the sum of restore (11s) + build (15s) would be 26 seconds. Consider updating to ~26 seconds or explaining why it's faster when combined.