Skip to content

fix: some minor issue in local-build #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RadNotRed merged 1 commit into from
Nov 4, 2025
Merged

fix: some minor issue in local-build #1515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions src/dependencies/local-build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,16 +468,13 @@ try {
$relative = $file.Name
}

if ($IsLinuxPlatform -or $IsMacOSPlatform) {
# normalize slashes for non-windows platforms
$relative = $relative -replace '\\', '/'
}
$relative = $relative -replace '\\', '/'

$relative
}

# write the file list so 7-zip can work through the tree efficiently
$relativePaths | Set-Content -Path $filesListPath -Encoding UTF8
$utf8NoBom = New-Object System.Text.UTF8Encoding $false
[System.IO.File]::WriteAllLines($filesListPath, $relativePaths, $utf8NoBom)

$passwordArgs = @()
if (-not $NoPassword) {
Expand All @@ -491,12 +488,8 @@ try {
}
$archiveArgs += $passwordArgs
$archiveArgs += $apbxPath
if ($IsWindowsPlatform) {
$archiveArgs += '@"{0}"' -f $filesListPath
} else {
# p7zip refuses -spf with relative paths so use plain @$list
$archiveArgs += "@$filesListPath"
}
# dont add extra quotes around the @ syntax as it breaks 7z parser
$archiveArgs += "@$filesListPath"

Invoke-SevenZip -ArgumentList $archiveArgs -ErrorContext 'Creating APBX archive' -ArchivePath $apbxPath

Expand Down